Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: fix outdated info #979

Merged
merged 2 commits into from
Apr 23, 2019
Merged

README: fix outdated info #979

merged 2 commits into from
Apr 23, 2019

Conversation

weissi
Copy link
Member

@weissi weissi commented Apr 23, 2019

Motivation:

The link to swift.org linked to the Swift 5 development versions but now
it's released. We also mentioned swift-nio-{http2,ssl,extras,transport-services}
but we already mention them in a more prominent place.

Modifications:

Remove outdated/duped info.

Result:

Better readme

Motivation:

The link to swift.org linked to the Swift 5 development versions but now
it's released. We also mentioned swift-nio-{http2,ssl,extras,transport-services}
but we already mention them in a more prominent place.

Modifications:

Remove outdated/duped info.

Result:

Better readme
@weissi weissi requested a review from normanmaurer April 23, 2019 15:33
@tomerd
Copy link
Member

tomerd commented Apr 23, 2019

flaky test? @swift-nio-bot test this please

10:49:11 Fatal error: Posix wrapper adds more than 20% overhead (with wrapper: 0.8163410425186157, without: 0.6731261014938354: file /tmp/.swift-nio-syscall-wrappers-sh-test_myuiEq/syscallwrapper/Sources/syscallwrapper/SystemCallWrapperHelpers.swift, line 124
10:49:11 /code/IntegrationTests/tests_02_syscall_wrappers/test_01_syscall_wrapper_fast.sh: line 45: 13246 Illegal instruction     (core dumped) "$swift_binary" run -c release -Xswiftc -DRUNNING_INTEGRATION_TESTS

/cc @weissi

@weissi
Copy link
Member Author

weissi commented Apr 23, 2019

@tomerd that's a performance test which sometimes fails if the CI is running too much stuff at the same time... When we do the performance effort, this one can go out of the unit test suite...

@weissi weissi merged commit 902cf2e into apple:master Apr 23, 2019
@weissi weissi deleted the jw-outdated-readme branch April 23, 2019 19:21
@Lukasa Lukasa added this to the 2.1.0 milestone May 9, 2019
@Lukasa Lukasa added the 🔨 semver/patch No public API change. label May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants