The future is now #136
Merged
The future is now #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Real conformance for Float16.
These cases expose a bug in the current implementation; because the split of the exponent into high and low parts may produce numbers with different signs, if both parts overflow or underflow, we can end up with 0 * infinity = NaN, when the result should actually be either zero or infinity.
Just-added tests expose this issue, where the split of n into high/low parts could produce parts with different signs. If both x**high and x**low then overflow and underflow, the resulting computation would be 0*inf (or inf*0) and produce NaN instead of either zero or infinity.
Somewhat better implementation of pow(x,n) for Float16.
Make 'Complex' differentiable.
build: add initial CMake based build system
finagolfin
reviewed
Aug 4, 2020
This isn't actually quite the right check; what we really want is to use availability on Darwin platforms, but swift version on other platforms (that don't have the standard library in an SDK). But there's no good way to do that, so we simply make it unconditionally unavailable for earlier versions of Swift.
|
@compnerd Can you sanity-check the windows build with this? |
rxwei
approved these changes
Aug 4, 2020
|
@stephentyrone sure, I'll check it tomorrow. |
|
This seems to have caused some issues on Windows, specifically in the tests: |
|
Fixed the build issue with #137. That uncovers a few failures: |
|
Ok, I'll relax the tolerances for these tests on Windows for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the experimental 5.3 feature branch into master, behind a Swift version check.
This makes Swift Numerics extensions for Float16 available if the following criteria are satisfied:
This also adds a Swift version check for differentiable features; they are now only available when using Swift 5.3 or later, while previously they only checked if _Differentiation could be imported.