add flag to disable building with testablity when running tests #4119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
commented
Feb 10, 2022
| @@ -138,6 +138,10 @@ struct TestToolOptions: ParsableArguments { | |||
| @Option(help: "Test the specified product.") | |||
| var testProduct: String? | |||
|
|
|||
| /// Generate LinuxMain entries and exit. | |||
| @Flag(name: .customLong("testable-imports"), inversion: .prefixedEnableDisable, help: "Enable or disable testable imports. Enabled by default.") | |||
| var enableTestableImports: Bool = true | |||
There was a problem hiding this comment.
the flag is --disable-testable-imports. ideas for a different name welcome. the user facing feature is testable imports so this is what I went with.
|
@swift-ci please smoke test |
tomerd
changed the title
tomerd
added
the
ready
abertelrud
approved these changes
Feb 10, 2022
|
@swift-ci smoke test |
tomerd
added
WIP
motivation: allow building tests without testability (testable imports), this can increase build / test cycles when tests do not require the testable imports feature since more is cachable changes: * add a --disable-testable-imports flag to "swift test" with which tests are build without the testablity feature * add tests rdar://82448144
tomerd
force-pushed
the
radar/82448144
branch
from
40331d1
to
ad7bf44
Compare
|
@swift-ci please smoke test |
tomerd
added
ready
neonichu
approved these changes
Feb 11, 2022
tomerd
added a commit
that referenced
this pull request
Feb 14, 2022
motivation: keep change log up to date changes: * add 5.7 section * document user facing API changes in #4119
Merged
tomerd
added a commit
that referenced
this pull request
Feb 14, 2022
motivation: keep change log up to date changes: * add 5.7 section * document user facing API changes in #4119
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: give users an option to build the tests without testability (testable imports). this can increase build / test cycles when tests do not require the testable imports feature, so build artifacts are more is cachable
changes:
--disable-testable-importsflag toswift testwith which tests are build without the testability feature-enable-testingwhen building test modules as it is required for test discoveryrdar://82448144