Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 5.7.md #5901

Merged
merged 10 commits into from
Jan 23, 2023
Merged

Create 5.7.md #5901

merged 10 commits into from
Jan 23, 2023

Conversation

elsh
Copy link
Contributor

@elsh elsh commented Nov 15, 2022

release notes for 5.7

@elsh
Copy link
Contributor Author

elsh commented Nov 15, 2022

Apparently 5.7 release notes weren't pushed before. Any thoughts on how to polish the notes?

@tomerd
Copy link
Contributor

tomerd commented Nov 15, 2022

Apparently 5.7 release notes weren't pushed before.

where did the proposed content come from? Looks like this was copied from the changelog?

@neonichu
Copy link
Contributor

where did the proposed content come from? Looks like this was copied from the changelog?

Yep, just the changelog. We probably want to workshop it a bit, but we just noticed the missing file while creating the 5.8 version bump PR.

@tomerd
Copy link
Contributor

tomerd commented Nov 15, 2022

yea we should probably add some more narrative and/or include additional changes if they had use facing impact

Co-authored-by: Yim Lee <yim_lee@apple.com>
Modules with the same name from different packages can now be disambiguated by module aliasing [SE-0339](https://github.com/apple/swift-evolution/blob/main/proposals/0339-module-aliasing-for-disambiguation.md). When adding a product dependency for a target in a package manifest, use a new parameter `moduleAliases` to provide a new unique name for a conflicting module.


* [#4119]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we retitle this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this section? Do we need to use a different title? All the other ones have proper titles.

@tomerd
Copy link
Contributor

tomerd commented Dec 22, 2022

@yim-lee @elsh @neonichu is this ready to merge?

@elsh
Copy link
Contributor Author

elsh commented Jan 14, 2023

@yim-lee @elsh @neonichu is this ready to merge?

What about the L18? Should we use a different title?

@elsh elsh closed this Jan 14, 2023
@neonichu
Copy link
Contributor

Hm, was this closed accidentally? I think we still want to backfill the 5.7 release notes, right?

@elsh elsh reopened this Jan 17, 2023
@elsh
Copy link
Contributor Author

elsh commented Jan 17, 2023

Oops, accidentally got closed. Reopened. We still need to address [#4119]. Any comments? @neonichu

@elsh
Copy link
Contributor Author

elsh commented Jan 20, 2023

@swift-ci smoke test

@neonichu
Copy link
Contributor

@swift-ci smoke test macOS

@elsh elsh merged commit 4e02bc0 into main Jan 23, 2023
@elsh elsh deleted the elsh-patch-1 branch January 23, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants