Support field separators on the last field of a message field. #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://protobuf.dev/reference/protobuf/textformat-spec/#fields calls out that `MessageField` and `ScalarField` both can be followed by a separator (`,` or `;`). https://protobuf.dev/reference/protobuf/textformat-spec/#message then replies on this to handle the separators within a message field. The existing parsing was accepting separators after all fields for top level fields, but when the decoder was for a message field (i.e. - there is a terminator stop at), it wouldn't properly the final separator followed by terminator correctly.
tbkka
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://protobuf.dev/reference/protobuf/textformat-spec/#fields calls out that
MessageFieldandScalarFieldboth can be followed by a separator (,or;).https://protobuf.dev/reference/protobuf/textformat-spec/#message then replies on this to handle the separators within a message field.
The existing parsing was accepting separators after all fields for top level fields, but when the decoder was for a message field (i.e. - there is a terminator stop at), it wouldn't properly the final separator followed by terminator correctly.