Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy interferes with healthcheck #456

Closed
McPo opened this issue Jan 21, 2020 · 1 comment · Fixed by #457
Closed

Proxy interferes with healthcheck #456

McPo opened this issue Jan 21, 2020 · 1 comment · Fixed by #457
Assignees
@appleboy
Labels
bug

Comments

@McPo
Copy link
Contributor

McPo commented Jan 21, 2020 •
edited
Loading

If you set the proxy via the config file http_proxy:, the docker healthcheck gorush --ping attempts to use the proxy. Which results in localhost (used by the healthcheck) resolving to the proxy as opposed to the container.

received request to: GET localhost:8088/healthz
Error: connect ECONNREFUSED 127.0.0.1:8088

Ive worked around this issue by using HTTP_PROXY env variables. (In my case this is actually preferred). You could also disable the healthcheck as a temp workaround.

A proper fix to this issue would be to have gorush --ping implicitly ignore the proxy, or have it explicit gorush --no-proxy --ping
@appleboy
Copy link
Owner

@McPo I will take it and we don't need to set any proxy in gorush --ping command.

@appleboy appleboy self-assigned this Jan 25, 2020
@appleboy appleboy added the bug label Jan 25, 2020
appleboy added a commit that referenced this issue Jan 25, 2020
@appleboy
chore(healthy): disable proxy in healthy check
3a37733 
fixed: #456

Don’t use Go’s default HTTP client (in production)

ref: https://medium.com/@nate510/don-t-use-go-s-default-http-client-4804cb19f779
@appleboy appleboy mentioned this issue Jan 25, 2020
Merged
appleboy added a commit that referenced this issue Jan 25, 2020
@appleboy
chore(healthy): disable proxy in healthy check (#457)
850509e 
fixed: #456

Don’t use Go’s default HTTP client (in production)

ref: https://medium.com/@nate510/don-t-use-go-s-default-http-client-4804cb19f779
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@appleboy appleboy

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(healthy): disable proxy in healthy check appleboy/gorush
2 participants
@appleboy @McPo