When queue is full, requests hang because Wait.Done() is not called on the affected notification #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t group instead of hanging
…t group as it is safer
Codecov Report
@@ Coverage Diff @@
## master #430 +/- ##
==========================================
- Coverage 83.97% 83.66% -0.32%
==========================================
Files 19 19
Lines 1348 1353 +5
==========================================
Hits 1132 1132
- Misses 173 178 +5
Partials 43 43
Continue to review full report at Codecov.
|
appleboy
approved these changes
Oct 16, 2019
appleboy
pushed a commit
that referenced
this pull request
Oct 17, 2019
* if queue is full then mark notification as failed and unblock the wait group instead of hanging * use WaitDone() function instead of calling Done() on notification wait group as it is safer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing a few scenarios I noticed that whenever tryEnqueue fails on a notification due to the queue not being available then the request will block on wg.Wait() in Sync mode which will lead the request to hang.
My proposed fix returns the failed notifications to the client so that it can act accordingly