chore(rpc): graceful shutdown for RPC server #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graceful shutdown for grpc service.
golangcibot
reviewed
Feb 4, 2020
| return nil | ||
| var g errgroup.Group | ||
| g.Go(func() error { | ||
| select { |
There was a problem hiding this comment.
S1000: should use a simple channel send/receive instead of select with a single case (from gosimple)
Codecov Report
@@ Coverage Diff @@
## master #463 +/- ##
==========================================
- Coverage 82.95% 82.72% -0.24%
==========================================
Files 20 20
Lines 1414 1418 +4
==========================================
Hits 1173 1173
- Misses 193 197 +4
Partials 48 48
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
graceful shutdown for grpc service.
fixed #462