Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gorush): add timeout for http client #473

Merged
merged 2 commits into from
Feb 24, 2020
Merged

chore(gorush): add timeout for http client #473

merged 2 commits into from
Feb 24, 2020

Conversation

appleboy
Copy link
Owner

dispatch feedback url

See: #449

@codecov-io
Copy link

codecov-io commented Feb 24, 2020

Codecov Report

Merging #473 into master will increase coverage by 0.1%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #473     +/-   ##
=========================================
+ Coverage   80.81%   80.92%   +0.1%     
=========================================
  Files          20       20             
  Lines        1423     1431      +8     
=========================================
+ Hits         1150     1158      +8     
  Misses        220      220             
  Partials       53       53
Impacted Files Coverage Δ
gorush/notification_apns.go 84.5% <0%> (ø) ⬆️
gorush/notification_fcm.go 79.48% <0%> (ø) ⬆️
config/config.go 94.11% <100%> (+0.07%) ⬆️
gorush/feedback.go 90.9% <100%> (+4.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e85252b...c6ea67a. Read the comment docs.

@appleboy appleboy merged commit 5262255 into master Feb 24, 2020
@appleboy appleboy deleted the dispatch branch February 24, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants