Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Redis stats storage concurrency issues #478

Merged
merged 2 commits into from
Feb 29, 2020
Merged

Conversation

yaronius
Copy link
Contributor

Fixes #477

@appleboy appleboy added the bug label Feb 29, 2020
@codecov-io
Copy link

codecov-io commented Feb 29, 2020

Codecov Report

Merging #478 into master will decrease coverage by <.01%.
The diff coverage is 89.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #478      +/-   ##
==========================================
- Coverage   80.92%   80.91%   -0.01%     
==========================================
  Files          20       20              
  Lines        1431     1436       +5     
==========================================
+ Hits         1158     1162       +4     
- Misses        220      221       +1     
  Partials       53       53
Impacted Files Coverage Δ
storage/redis/redis.go 100% <100%> (ø) ⬆️
gorush/notification_fcm.go 80.15% <83.33%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5262255...63e054b. Read the comment docs.

@appleboy appleboy merged commit b583867 into appleboy:master Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redis stats storage concurrency issues
3 participants