Concurrent ios pushes

[McPo]

Runs client.Push concurrently for iOS pushes, drastically increases performance of gorush. I have tested this along with ensuring logs are return in sync mode and that retries are made. It all seems ok. (Although maybe Im missing something??)

Resolves (hopefully) #470

[McPo]

It appears that tests are failing due to the redis service not running

=== RUN   TestRedisServerError
556	2020/04/21 16:32:48 Can't connect redis server: dial tcp 192.168.240.2:6370: connect: connection refused
557	--- PASS: TestRedisServerError (0.00s)
558	=== RUN   TestRedisEngine
559	--- PASS: TestRedisEngine (0.00s)
560	PASS
561	coverage: 100.0% of statements
562	ok  	github.com/appleboy/gorush/storage/redis	0.011s	coverage: 100.0% of statements
563	FAIL

[slimus]

Is it possible to write some bench tests for Ios send push case?

[yaronius]

It appears that tests are failing due to the redis service not running

It seems to me that Redis is OK and the problem with tests is in the Makefile:

make: *** [Makefile:98: test] Error 1

P.S. Nope, my bad, Makefile is OK as well... Strange...

[slimus]

@McPo @yaronius don't worry about tests.

[McPo]

Is it possible to write some bench tests for Ios send push case?

How would you want such bench test to be done? Would you want it automated with an assert, or just report. Would a separate test suite maybe be more appropriate?

Say mock out the the client.push to sleep for 1 seconds. Have it send 10 notifications, check if it return less than 2 seconds?

The thing is, we are then basically testing that the co-routine is running in parallel. Which is another reason I was using the external library to limit it, It could then have been argued we were basically just re-testing library code.

I don't think theres a massive benefit to adding automated benchmarks tests. Id suggest maybe adding something similar to @yaronius script, maybe running it in sync mode and using time.

[slimus]

lgtm

[McPo]

I thought PushToIOS would've been queued, ie If an incoming push was being processed, if another incoming push was made it would wait till the current one had finished. This isn't the case, as such the MaxConcurrentPushes was only being enforce on a per incoming push basis.

So Ive since made it that MaxConcurrentPushes applies across all pushes by moving the channel to global.

One caveat with this is, a new push will be processed with the same priority as the previous one, ie they will be mixed in. As opposed to finishing the first push and then moving one. Its neither correct nor incorrect.

I think thats us now.

[appleboy]

@McPo Please fix the error: https://cloud.drone.io/appleboy/gorush/322/1/8

[McPo]

@McPo Please fix the error: https://cloud.drone.io/appleboy/gorush/322/1/8

Done! Sorry about that.
Looks better now, tests still failing due to redis though.

[appleboy]

fail in TestPushToIOS func.

[appleboy]

@McPo Thanks.