make Huawei configs compatible with HMS Core 4.0 #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apikey changed to appsecret for huawei push service config
appleboy
requested changes
Mar 27, 2021
config/config.go
Outdated
| conf.Huawei.APIKey = viper.GetString("huawei.apikey") | ||
| conf.Huawei.APPId = viper.GetString("huawei.appid") | ||
| conf.Huawei.AppSecret = viper.GetString("huawei.appsecret") | ||
| conf.Huawei.AppId = viper.GetString("huawei.appid") |
There was a problem hiding this comment.
Please fix the lint error https://cloud.drone.io/appleboy/gorush/503/1/4
There was a problem hiding this comment.
Hi, I fixed the errors for AppID, but make lint now throws different error. When I try make lint locally it doesn't show any errors. Can you check it out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huawei token and push urls are changed to be compatible with
HMS4.0and misleading ApiKey word changed to AppSecret for huawei configs