Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fcm): notification handling logic for sound field #797

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Conversation

appleboy
Copy link
Owner

  • Remove IsGRPC field from PushNotification struct
  • Simplify condition by removing IsGRPC check in GetAndroidNotification
  • Add checks for APNS and Android fields in GetAndroidNotification
  • Remove IsGRPC initialization in Send method of Server

fix #795

appleboy added 2 commits July 17, 2024 19:19
- Remove `IsGRPC` field from `PushNotification` struct
- Simplify condition by removing `IsGRPC` check in `GetAndroidNotification`
- Add checks for `APNS` and `Android` fields in `GetAndroidNotification`
- Remove `IsGRPC` initialization in `Send` method of `Server`

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
- Change `req.Sound` type check from string to interface
- Add type assertion for `req.Sound` to string
- Ensure `req.APNS` and `req.Android` are only set if `req.Sound` is a string

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@appleboy appleboy merged commit a82bebe into master Jul 17, 2024
10 checks passed
@appleboy appleboy deleted the sound branch July 17, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification sound is broken in version 1.18
1 participant