Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

Issue 4, Button to random episode #12

Merged
merged 5 commits into from
Nov 9, 2021
Merged

Issue 4, Button to random episode #12

merged 5 commits into from
Nov 9, 2021

Conversation

DvdQzd
Copy link
Contributor

@DvdQzd DvdQzd commented Oct 6, 2021 •
edited
Loading

Closes #4

@DvdQzd DvdQzd mentioned this pull request Oct 6, 2021
Closed
applejag
applejag suggested changes Oct 6, 2021
View reviewed changes
Copy link
Owner

@applejag applejag left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Some changes though

Also, in your PR description, you may use "closes", "fixes", or "resolves", but "solves" does not link the issue for closing:

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

src/sections/EpisodeListSection.svelte Outdated Show resolved Hide resolved
src/libs/episodes-repo.ts Outdated Show resolved Hide resolved
@applejag
Copy link
Owner

applejag commented Nov 9, 2021

I pushed the changes myself. Hope you don't mind!

@applejag applejag merged commit be4408e into applejag:master Nov 9, 2021
@applejag applejag mentioned this pull request Nov 9, 2021
Merged
@DvdQzd
Copy link
Contributor Author

DvdQzd commented Nov 9, 2021

I pushed the changes myself. Hope you don't mind!

Not at all!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@applejag applejag applejag requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Button to open random episode
2 participants
@DvdQzd @applejag