Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/users endpoint #615

Open
wants to merge 4 commits into
base: api-v2
Choose a base branch
from
Open

/users endpoint #615

wants to merge 4 commits into from

Conversation

toastts
Copy link
Contributor

@toastts toastts commented Nov 30, 2022

changed /user/stats to /users/stats
changed /user/export -> /users/export
updated docstrings to reflect changes

changed the handler for stats to have consistent naming semantics with the other handlers

resolves #574

@gmelodie gmelodie added the APIv2 API v2 changes label Nov 30, 2022
@gmelodie gmelodie changed the title /users endpoint api-v2 /users endpoint Nov 30, 2022
Copy link
Contributor

@gmelodie gmelodie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order for this to get merged, I'd like to see all /user endpoints gone, either because they became /users or because they got moved somewhere else

Comment on lines 145 to 149
user.GET("/api-keys", withUser(s.handleUserGetApiKeys))
user.POST("/api-keys", withUser(s.handleUserCreateApiKey))
user.DELETE("/api-keys/:key_or_hash", withUser(s.handleUserRevokeApiKey))
user.GET("/export", withUser(s.handleUserExportData))
user.PUT("/password", withUser(s.handleUserChangePassword))
user.PUT("/address", withUser(s.handleUserChangeAddress))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to keep other /user endpoints

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toastts any news here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIv2 API v2 changes
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants