-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/users endpoint #615
base: api-v2
Are you sure you want to change the base?
/users endpoint #615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order for this to get merged, I'd like to see all /user
endpoints gone, either because they became /users
or because they got moved somewhere else
user.GET("/api-keys", withUser(s.handleUserGetApiKeys)) | ||
user.POST("/api-keys", withUser(s.handleUserCreateApiKey)) | ||
user.DELETE("/api-keys/:key_or_hash", withUser(s.handleUserRevokeApiKey)) | ||
user.GET("/export", withUser(s.handleUserExportData)) | ||
user.PUT("/password", withUser(s.handleUserChangePassword)) | ||
user.PUT("/address", withUser(s.handleUserChangeAddress)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to keep other /user
endpoints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@toastts any news here?
changed
/user/stats
to/users/stats
changed
/user/export
->/users/export
updated docstrings to reflect changes
changed the handler for stats to have consistent naming semantics with the other handlers
resolves #574