This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
Add timestamp on the note field for the submit transaction #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seromenho
force-pushed
the
chore/unique-tx
branch
from
2ed6544
to
1341696
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A transaction might get accepted on the transaction pool but not finalised.
Adding a special (timestamp) note on the submitted transaction will make a different transaction meaning that it will be accepted and we can try to re-submit the same VRF round.
From now on instead, when trying to submit the same VRF round, instead of errors saying that the transaction is already on the transaction pool we will have assertion failures because we are trying to submit a not valid VRF round that was previously submitted.