This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
Add client deployment script and update README #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alaanzr
force-pushed
the
add-uglify-script
branch
from
414ebf1
to
b6cd520
Compare
mariogemoll
suggested changes
Dec 7, 2018
.circleci/config.yml
Outdated
| command: echo "//registry.npmjs.org/:_authToken=$PRIVATE_NPM_TOKEN" > ~/.npmrc | ||
| - run: | ||
| name: Publish to NPM | ||
| command: npm publish |
There was a problem hiding this comment.
Does the publish need to happen from the client-build dir? Then I think it needs to be cd client-build && npm publish
.circleci/config.yml
Outdated
| - publish_client_version_to_npm: | ||
| context: org-global | ||
| requires: | ||
| - generate_client_version |
There was a problem hiding this comment.
Would be good to add - publish_to_npm as a requirement, so that a client version is only published for a successfully published normal version.
Plus we should also test the client version. So there should also be a job test_client_version (I guess we can just reuse the tests of the normal version?). And publish_to_npm should depend on both test and test_client_version (so we also don't push a "normal" version when we're not sure the client version also works).
Alaanzr
force-pushed
the
add-uglify-script
branch
from
b51b949
to
bdd8476
Compare
Alaanzr
force-pushed
the
add-uglify-script
branch
3 times, most recently
from
4175d4a
to
d3db687
Compare
Alaanzr
force-pushed
the
add-uglify-script
branch
from
d3db687
to
a65161a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.