tcprewrite: handle malformed and unsupported packets as soft errors #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of hard failing on malformed packets, treat them as soft errors and skip them. This concerns both malformed packets (eg. too short to contain the expected protocol headers) and unsupported packets (eg. fragmented IPv6 packets). This is a partial fix for appneta#611 Signed-off-by: Gabriel Ganne <gabriel.ganne@gmail.com>
I had a closer look, and it seems worth the risk. This is great to have, enabling edits on short caplen captures. I suspect that we may see some bugs come out of this at some point, but for now I cannot find any. Thanks again @GabrielGanne for a great contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is in response to #611
The ticket issue is caused by the packet being rewritten to be
unsupported (fragmented IPv6 packet). The issue would be the same
for malformed packets however.
The current behavior is to fail quite brutally by stopping all processing
right away. I propose to just skip those packets instead.
Best regards,