Skip to content
This repository has been archived by the owner on Oct 14, 2020. It is now read-only.

Avoid chmod on Win32 #22

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Avoid chmod on Win32 #22

merged 1 commit into from
Jul 3, 2020

Conversation

siketyan
Copy link
Member

@siketyan siketyan commented Jul 3, 2020

On Windows, Chromium resolver causes the following error excluding the first launch:

Error: EPERM: operation not permitted, open 'C:\Users\Siketyan\AppData\Local\Temp\.devoirs\chromium\chrome.exe'

The reason of the problem is the permission system is different between Unix and Windows.
So this PR solves it by avoiding mode changing only on Win32 platform.

@siketyan siketyan added the bug Something isn't working label Jul 3, 2020
@siketyan siketyan self-assigned this Jul 3, 2020
Copy link

@raiga0310 raiga0310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siketyan siketyan merged commit 8176d13 into master Jul 3, 2020
@siketyan siketyan deleted the fix-win32-permission branch July 3, 2020 14:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants