Skip to content
This repository has been archived by the owner on Oct 14, 2020. It is now read-only.

Add GUI #25

Merged
merged 12 commits into from
Jul 6, 2020
Merged

Add GUI #25

merged 12 commits into from
Jul 6, 2020

Conversation

siketyan
Copy link
Member

@siketyan siketyan commented Jul 4, 2020

Closes #24

image

@siketyan siketyan added the enhancement New feature or request label Jul 4, 2020
@siketyan siketyan self-assigned this Jul 4, 2020
@siketyan
Copy link
Member Author

siketyan commented Jul 4, 2020 •
edited
Loading

TODO

  • Support Timezone
  • Resolve assets location issue

@siketyan siketyan marked this pull request as ready for review July 5, 2020 13:48
MikuroXina
MikuroXina suggested changes Jul 6, 2020
View reviewed changes
src/services/gui/client.ts Outdated Show resolved Hide resolved
kawaemon
kawaemon approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@kawaemon kawaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

puppeteerをGUIに転用するの凄い頭いいなーと思いました

@siketyan siketyan requested a review from MikuroXina July 6, 2020 08:18
@siketyan siketyan merged commit 3a2340f into master Jul 6, 2020
@siketyan siketyan deleted the gui branch July 6, 2020 08:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikuroXina MikuroXina MikuroXina approved these changes

@kawaemon kawaemon kawaemon approved these changes

@isso0424 isso0424 Awaiting requested review from isso0424

@shun-shobon shun-shobon Awaiting requested review from shun-shobon

Assignees

@siketyan siketyan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GUI support
3 participants
@siketyan @MikuroXina @kawaemon