[SE-4475] Add transcripts download and refactor captions download #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkulkark
previously approved these changes
Jun 10, 2021
|
Hello @OmarIthawi, |
|
@gabor-boros let's please wait till #15 is merged. Then please rebase this pull request to run tests on GitHub. |
|
@gabor-boros please rebase over #15 so we can run tests on GitHub Actions. |
|
Hello @OmarIthawi, |
The "download transcripts" button already exists, though it actually downloads the captions not transcripts. Hence that button -- and the related code -- is renamed to use the term "captions". Because the original intention was to add a download transcripts button in appsembler#6, this commit adds the originally required button and functionality as well. Besides that, it worth mentioning the transcripts are different in a way compared to captions in a way that it is not bind to any language.
gabor-boros
force-pushed
the
gabor/add-transcripts-download
branch
from
ed1d6a2 to
e9943c5
Compare
|
@OmarIthawi the PR is rebased now. 🤞 -- no further changes will come for now |
OmarIthawi
approved these changes
Jun 12, 2021
OmarIthawi
added a commit
that referenced
this pull request
Jun 12, 2021
Release #11 in addition to few package upgrades.
Merged
|
Release is available on https://github.com/appsembler/xblock-wistia/releases/tag/0.5 |
|
@OmarIthawi didn't you miss |
|
Fixed that. Thanks @gabor-boros! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "download transcripts" button already exists, though it actually downloads the captions, not transcripts. Hence that button -- and the related code -- is renamed to use the term "captions". Because the original intention was to add a download transcripts button in #6, this commit adds the originally required button and functionality as well.
Besides that, it worth mentioning the transcripts are different in a way compared to captions in a way that it is not bound to any language.
Dependencies: None
Screenshots:
Only captions:
Only transcripts:
Both transcripts and captions:
Sandbox URL: Sandbox URL
Merge deadline: None
Testing instructions:
--- OR ---
Author notes and concerns:
Wistia using caching for the transcripts, therefore, in case of a transcript is changed or removed, it may take some time to be available/unavailable.
Reviewers