Add deprecation warning to instrumentationsLoaded #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `instrumentationsLoaded()` helper is not required anymore since the introduction of `sdk.start()` asynchronous OpenTelemetry load. This commits removes any logic related to the helper and a deprecation warning. The client attribute is also removed as it was only used by the helper.
3 tasks
tombruijn
approved these changes
May 24, 2023
unflxw
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
instrumentationsLoaded()helper is not required anymore since the introduction ofsdk.start()asynchronous OpenTelemetry load. This commits removes any logic related to the helper and a deprecation warning.The client attribute is also removed as it was only used by the helper.
Part of: #877