You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The minutely probes thread doesn't drift, as long as all probes are done within a minute. We use the wait_time method to calculate the next 0 second in a minute and run the next iteration over the probes then. This follows the minutely probes integrations guide spec.
Individual probes can drift. They're all run in sequence, if probe 1 is slow, probe 2 runs later. That's fine if probe 1 is always slow, but if it's only intermeditatly slow, probes that run after it could drift a bit back and forth. I don't think we can cover this case unless we run each probe in its own thread.
I'm okay with how it works now.
Things we can do to improve this is to:
Track if the total of all probes take more than a minute and log an error to the AppSignal log.
Track how long individual probes take and log a warning if it takes longer than some arbitrary number, like 5 seconds
Log an error when the total probes iteration takes more than a minute.
It's the 'minutely' probes process, and doesn't report accurate minutely
metrics if each iteration takes more than a minute.
Closes#814
Log an error when the total probes iteration takes more than a minute.
It's the 'minutely' probes process, and doesn't report accurate minutely
metrics if each iteration takes more than a minute.
Closes#814
As agreed upon in https://github.com/appsignal/integration-guide/pull/124, make sure that the minutely probes don't drift, so they don't actually calculate metrics over 1 minute and 5 seconds, for example.
TODO
The text was updated successfully, but these errors were encountered: