Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Snowflake Key Pair auth #2385

Merged
merged 6 commits into from
Sep 25, 2024
Merged

feat: Snowflake Key Pair auth #2385

merged 6 commits into from
Sep 25, 2024

Conversation

harshilp24
Copy link
Contributor

@harshilp24 harshilp24 commented Jul 2, 2024

Description

Provide a concise summary of the changes made in this pull request

Pull request type

Check the appropriate box:

Documentation tickets

Link to one or more documentation tickets:

Checklist

From the below options, select the ones that are applicable:

  • Checked for Grammarly suggestions.
  • Adhered to the writing checklist.
  • Adhered to the media checklist.
  • Verified and updated cross-references or added redirect rules.
  • Tested the redirect rules on deploy preview.
  • Validated the modifications made to the content on the deploy preview.
  • Validated the CSS modifications on different screen sizes.

Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appsmith-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 11:56am

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshilp24 should we have one screenshot each for basic and key pair auth? The one added in this PR shows the key pair method

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should add screenshots for each authentication method. The UI for selecting the method is simple and easy to understand; we only add screenshots when we think users might get confused or if the UI is difficult to configure.

@harshilp24 harshilp24 marked this pull request as draft August 14, 2024 08:17
@harshilp24 harshilp24 marked this pull request as ready for review September 24, 2024 10:54
@jnikhila jnikhila merged commit 3305d84 into main Sep 25, 2024
5 checks passed
@jnikhila jnikhila deleted the snowflake-key-auth branch September 25, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: Snowflake - Key Pair - Auth type
4 participants