fix: Enabled js mode by default for Table and Select widget form disp…

…lay ui button (#39032)
appsmithorg · Feb 6, 2025 · 35ba3cc · 35ba3cc
1 parent 4b20f9f
commit 35ba3cc
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 10 deletions.
diff --git a/app/client/cypress/e2e/Regression/ClientSide/BugTests/ApiBugs_Spec.ts b/app/client/cypress/e2e/Regression/ClientSide/BugTests/ApiBugs_Spec.ts
@@ -30,7 +30,7 @@ describe(
       dataSources.AddSuggestedWidget(Widgets.Table);
       debuggerHelper.AssertErrorCount(0);
       table.WaitUntilTableLoad(0, 0, "v2");
-      propPane.AssertPropertiesDropDownCurrentValue("Table data", "Api1");
+      propPane.ValidatePropertyFieldValue("Table data", "{{Api1.data}}");
 
       // Create another API so that it returns object response
       apiPage.CreateAndFillApi(
@@ -108,9 +108,9 @@ describe(
       );
       debuggerHelper.AssertErrorCount(0);
       table.WaitUntilTableLoad(0, 0, "v2");
-      propPane.AssertPropertiesDropDownCurrentValue(
+      propPane.ValidatePropertyFieldValue(
         "Table data",
-        "ARRAY_RESPONSE",
+        "{{ARRAY_RESPONSE.data}}",
       );
 
       // Create API so that it returns object response

diff --git a/app/client/cypress/e2e/Sanity/Datasources/Arango_Basic_Spec.ts b/app/client/cypress/e2e/Sanity/Datasources/Arango_Basic_Spec.ts
@@ -334,14 +334,14 @@ if (CURRENT_REPO == REPO.CE) {
         dataSources.EnterQuery(query);
         dataSources.RunQuery();
         dataSources.AddSuggestedWidget(Widgets.Table); //Binding to new table from schema explorer
-        propPane.AssertPropertiesDropDownCurrentValue("Table data", "Query6");
+        propPane.ValidatePropertyFieldValue("Table data", "{{Query6.data}}");
 
         EditorNavigation.SelectEntityByName("Query6", EntityType.Query);
         dataSources.AddSuggestedWidget(
           Widgets.Table,
           dataSources._addSuggestedExisting,
         );
-        propPane.AssertPropertiesDropDownCurrentValue("Table data", "Query6");
+        propPane.ValidatePropertyFieldValue("Table data", "{{Query6.data}}");
       });
 
       //To add test for duplicate collection name

diff --git a/...ient/src/PluginActionEditor/components/PluginActionResponse/components/BindDataButton.tsx b/...ient/src/PluginActionEditor/components/PluginActionResponse/components/BindDataButton.tsx
@@ -164,10 +164,7 @@ function getWidgetProps(
         props: {
           [fieldName]: `{{${actionName}.${suggestedWidget.bindingQuery}}}`,
           dynamicBindingPathList: [{ key: "tableData" }],
-          dynamicPropertyPathList:
-            suggestedWidget.bindingQuery === "data"
-              ? []
-              : [{ key: "tableData" }],
+          dynamicPropertyPathList: [{ key: "tableData" }],
         },
         parentRowSpace: 10,
       };

diff --git a/app/client/src/sagas/SnipingModeSagas.ts b/app/client/src/sagas/SnipingModeSagas.ts
@@ -76,7 +76,11 @@ export function* bindDataToWidgetSaga(
     : oneClickBindingQuery;
   let isDynamicPropertyPath = true;
 
-  if (bindingQuery === oneClickBindingQuery) {
+  if (
+    bindingQuery === oneClickBindingQuery &&
+    selectedWidget.type !== "TABLE_WIDGET_V2" &&
+    selectedWidget.type !== "SELECT_WIDGET"
+  ) {
     isDynamicPropertyPath = false;
   }