Skip to content

Commit

Permalink
fix: Reverted changes for skip client cache (#37782)
Browse files Browse the repository at this point in the history
## Description
Added command for migration


Fixes #
https://app.zenhub.com/workspaces/stability-pod-6690c4814e31602e25cab7fd/issues/gh/appsmithorg/appsmith/37768

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Enhanced the client build workflow for improved detection of modified
files.
- Streamlined conditions for executing build steps based on file
changes.
	- Refined caching mechanisms for Yarn and build artifacts.
	- Improved handling of Git LFS commands in the build process.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
sagar-qa007 authored Nov 27, 2024
1 parent 62724e9 commit 94768bd
Showing 1 changed file with 17 additions and 17 deletions.
34 changes: 17 additions & 17 deletions .github/workflows/client-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,23 +66,23 @@ jobs:
with:
fetch-tags: true

# - name: Get changed files in the client folder
# id: changed-files-specific
# uses: tj-actions/changed-files@v41
# with:
# files: "app/client/**"

- name: Updating the client changed file variable
- name: Get changed files in the client folder
id: changed-files-specific
run: echo "any_changed=true" >> "$GITHUB_OUTPUT"
uses: tj-actions/changed-files@v41
with:
files: "app/client/**"

#- name: Run step if any file(s) in the client folder change
# if: steps.changed-files-specific.outputs.any_changed == 'true'
# env:
# ALL_CHANGED_FILES: ${{ steps.changed-files-specific.outputs.all_changed_files }}
# run: |
# echo "One or more files in the server folder has changed."
# echo "List all the files that have changed: $ALL_CHANGED_FILES"
# - name: Updating the client changed file variable
# id: changed-files-specific
# run: echo "any_changed=true" >> "$GITHUB_OUTPUT"

- name: Run step if any file(s) in the client folder change
if: steps.changed-files-specific.outputs.any_changed == 'true'
env:
ALL_CHANGED_FILES: ${{ steps.changed-files-specific.outputs.all_changed_files }}
run: |
echo "One or more files in the server folder has changed."
echo "List all the files that have changed: $ALL_CHANGED_FILES"
- name: Check compliance
if: inputs.pr != 0 && steps.changed-files-specific.outputs.any_changed == 'true'
Expand Down Expand Up @@ -209,11 +209,11 @@ jobs:
git config --global user.email "$gituseremail"
git config --global user.name "$gituser"
git clone https://$cachetoken@github.com/appsmithorg/cibuildcache.git
git lfs install
git lfs migrate import --everything --yes
if [ "$reponame" = "appsmith" ]; then export repodir="CE"; fi
if [ "$reponame" = "appsmith-ee" ]; then export repodir="EE"; fi
cd cibuildcache/$repodir/release/client
git lfs install
git lfs migrate import --everything --yes
git lfs pull ./build.tar
mv ./build.tar ../../../../../build.tar
Expand Down

0 comments on commit 94768bd

Please sign in to comment.