Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: List widget does not support rating widget properly. #10691

Closed
1 task done
somangshu opened this issue Jan 27, 2022 · 4 comments · Fixed by #10737
Closed
1 task done

[Bug]: List widget does not support rating widget properly. #10691

somangshu opened this issue Jan 27, 2022 · 4 comments · Fixed by #10737
Assignees
Labels
Bug Something isn't working High This issue blocks a user from building or impacts a lot of users List Widget Issues related to the list widget Production Regressed Scenarios that were working before but have now regressed Verified When issue is retested post its fixed Widgets Product This label groups issues related to widgets

Comments

@somangshu
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

The list widget is supporting the rating widget for some reason any more. Out internal standup app has the widget used inside the list in today's update and you can see that the values are evaluated properly but not rendered on the widget.

I tried check this on a new list widget with a new rating widget, At first it works, but as soon as I try a binding the widget does not show default rating anymore, neither does is rectify the widget if the value is hardcoded

Steps To Reproduce

  1. add a list widget
  2. add a rating widget to the list
  3. observe that the rating widget shows the default rating right now
  4. replace the default rating with a dynamic binding now
  5. observe that the rating widget does not respond to any inputs anymore
  6. observe that changing the default rating back to hardcoded value also does not work

Environment

Production

Version

Cloud

@somangshu somangshu added Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Production Regressed Scenarios that were working before but have now regressed List Widget Issues related to the list widget labels Jan 27, 2022
@somangshu
Copy link
Contributor Author

@ohansFavour could you check if this is related to your change

@github-actions github-actions bot added Widgets Product This label groups issues related to widgets UI Building Pod labels Jan 27, 2022
@ohansFavour
Copy link
Contributor

Yes @somangshu , I am reverting the private widgets feature here .

@somangshu
Copy link
Contributor Author

@ohansFavour please take note if there was a migration written earlier, This might cause problems

@ohansFavour
Copy link
Contributor

Noted @somangshu. I will fix the edge cases.

@close-label close-label bot added the QA Needs QA attention label Feb 1, 2022
@YogeshJayaseelan YogeshJayaseelan added Verified When issue is retested post its fixed and removed QA Needs QA attention labels Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working High This issue blocks a user from building or impacts a lot of users List Widget Issues related to the list widget Production Regressed Scenarios that were working before but have now regressed Verified When issue is retested post its fixed Widgets Product This label groups issues related to widgets
Projects
None yet
3 participants