Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Evaluate PrivateWidgets to fix list widget children evaluation issue #10737

Merged
merged 1 commit into from
Feb 1, 2022
Merged

fix: Evaluate PrivateWidgets to fix list widget children evaluation issue #10737

merged 1 commit into from
Feb 1, 2022

Conversation

ohansFavour
Copy link
Contributor

@ohansFavour ohansFavour commented Jan 31, 2022 •
edited by github-actions bot
Loading

Description

Fixes #10691

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased 
// Code coverage diff between base branch:release and head branch: fix/edge-cases-in-private-widgets
Status File % Stmts % Branch % Funcs % Lines
🔴 total 55.01 (0) 36.49 (-0.01) 34.71 (-0.02) 55.4 (-0.01)
🟢 app/client/src/selectors/commentsSelectors.ts 85.25 (1.64) 64.71 (2.95) 73.33 (0) 90.59 (2.35)
🔴 app/client/src/utils/autocomplete/TernServer.ts 52.71 (-0.23) 40.83 (-0.84) 36.21 (0) 56.74 (-0.25)
🔴 app/client/src/workers/DataTreeEvaluator.ts 75.73 (-0.76) 56.25 (-0.99) 72.09 (-2.33) 75.56 (-0.81)

@vercel
Copy link

vercel bot commented Jan 31, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/2Q5rej3WEJYgR8ZMxXsNjd9NxGNd
✅ Preview: https://appsmith-git-fix-edge-cases-in-private-widgets-get-appsmith.vercel.app

@ohansFavour ohansFavour changed the title fix broken list widget fix: broken list widget Jan 31, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

3 similar comments
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@ohansFavour
Copy link
Contributor Author

/ok-to-test sha=ee5755b

@github-actions github-actions bot added the Bug Something isn't working label Jan 31, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1771349425.
Workflow: Appsmith External Integration Test Workflow.
Commit: ee5755b.
PR: 10737.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1771349425.
Commit: ee5755b.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Mean SD.Sample SD.Population
Click on table row
scripting 2616.13 2118.92 2207.26 2264.96 2150.06 2271.47 8.83 7.90
painting 51.56 14.88 28.64 15.24 17.25 25.51 61.19 54.72
rendering 312.2 306.64 287.02 309.93 290.2 301.2 3.89 3.48
Edit input
scripting 285.98 330.33 311.04 1525.27 332.06 556.94 97.25 86.98
painting 7.61 11.54 32.83 19.94 6.52 15.69 69.73 62.33
rendering 12.81 15.21 16.32 15.05 18.88 15.65 14.12 12.59
Clear input
scripting 780.55 721.06 766.73 1046.21 753.65 813.64 16.21 14.50
painting 5.32 6.46 6.65 5.63 6.68 6.15 10.24 9.11
rendering 191.67 200.68 181.95 177.91 193.82 189.21 4.87 4.35
Edit input again
scripting 278.38 272.67 319.62 281.32 287.88 287.97 6.43 5.75
painting 4.12 7.24 10.03 8.19 13 8.52 38.73 34.62
rendering 18.08 18.03 20.61 17.83 17.28 18.37 7.02 6.31

@ohansFavour ohansFavour marked this pull request as draft January 31, 2022 09:10
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@ohansFavour ohansFavour marked this pull request as ready for review January 31, 2022 10:58
@ohansFavour ohansFavour force-pushed the fix/edge-cases-in-private-widgets branch from ee5755b to 550821f Compare January 31, 2022 11:01
@ohansFavour
Copy link
Contributor Author

/ok-to-test sha= 550821f

rishabhrathod01
rishabhrathod01 approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@rishabhrathod01 rishabhrathod01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rishabhrathod01
Copy link
Contributor

/ok-to-test sha=550821f

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1772758607.
Workflow: Appsmith External Integration Test Workflow.
Commit: 550821f.
PR: 10737.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1772758607.
Commit: 550821f.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Mean SD.Sample SD.Population
Click on table row
scripting 2732.94 2129.29 2130.06 2103.41 2193.55 2257.85 11.85 10.60
painting 25.15 26.72 41.96 21.17 22.26 27.45 30.64 27.40
rendering 402.85 288.04 283.51 259.92 321.18 311.1 17.92 16.03
Edit input
scripting 282.81 303.33 322.12 346.96 373.84 325.81 10.98 9.82
painting 6.51 23.09 32.42 28.67 9.88 20.11 56.89 50.87
rendering 13.5 11.78 12.14 18.74 27.85 16.8 40.36 36.07
Clear input
scripting 728.93 751.94 755.66 787.47 748.09 754.42 2.80 2.51
painting 6.79 5.89 8.52 23.28 10.68 11.03 64.28 57.48
rendering 181.17 177.31 204.37 202.92 193.03 191.76 6.42 5.74
Edit input again
scripting 304.32 281.96 276.03 291.89 272.91 285.42 4.48 4.01
painting 17.87 6.41 5.27 17.45 12.24 11.85 50.04 44.73
rendering 19.18 18.63 21.85 17.25 18.66 19.11 8.84 7.90

@rishabhrathod01 rishabhrathod01 changed the title fix: broken list widget fix: Evaluate PrivateWidgets to fix list widget children evaluation issue Jan 31, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@ohansFavour ohansFavour force-pushed the fix/edge-cases-in-private-widgets branch from 550821f to b6178ae Compare January 31, 2022 16:28
@ohansFavour
Copy link
Contributor Author

/ok-to-test sha=b6178ae

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1773685807.
Workflow: Appsmith External Integration Test Workflow.
Commit: b6178ae.
PR: 10737.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1773685807.
Commit: b6178ae.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Mean SD.Sample SD.Population
Click on table row
scripting 2744.62 2166.09 2177.17 2312.55 2159.36 2311.96 10.81 9.67
painting 61.87 34.26 9.42 10.93 49.95 33.29 69.90 62.51
rendering 342.87 287.72 256.65 303.85 317.98 301.81 10.72 9.59
Edit input
scripting 310.83 328.67 354.46 336.35 306.42 327.35 5.97 5.34
painting 12.81 8.61 15.15 17.23 9.19 12.6 29.60 26.43
rendering 15.26 25.98 33.11 20.62 15.05 22 34.82 31.14
Clear input
scripting 775.23 760.17 752.21 774.71 811.34 774.73 2.93 2.62
painting 6.59 6.17 5.65 5.44 5.06 5.78 10.38 9.34
rendering 182.88 188.05 189.61 174.03 195.95 186.1 4.41 3.94
Edit input again
scripting 260.63 299 284.71 316.81 295.9 291.41 7.11 6.36
painting 5.74 8.49 4.88 6.34 5.97 6.28 21.34 19.11
rendering 18.92 19.84 18.43 19.65 18.65 19.1 3.25 2.88

@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1773685807.
Workflow: Appsmith External Integration Test Workflow.
Commit: b6178ae.
PR: 10737.

@github-actions
Copy link

github-actions bot commented Feb 1, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1773685807.
Commit: b6178ae.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Mean SD.Sample SD.Population
Click on table row
scripting 2760.34 2732.86 3552.94 2703.91 2650.44 2880.1 13.14 11.75
painting 28.89 20.09 41.94 9.96 17.11 23.6 52.12 46.61
rendering 311.67 330.52 469.23 309.79 295.56 343.35 20.81 18.61
Edit input
scripting 428.48 451.28 399.63 388.1 436.21 420.74 6.22 5.57
painting 23.4 13.39 3.33 10.97 6.8 11.58 66.06 59.15
rendering 19.42 32.32 15.15 15.07 28.97 22.19 36.10 32.27
Clear input
scripting 964.33 928.98 918.94 1037.71 896.26 949.24 5.82 5.20
painting 7.5 24.51 18.59 14.39 9.03 14.8 47.23 42.23
rendering 221.46 230.02 231.98 251.29 227.39 232.43 4.84 4.33
Edit input again
scripting 357.46 428 737.1 424.11 421.95 473.72 31.69 28.34
painting 9.06 18.04 7.64 14.95 17.3 13.4 35.60 31.87
rendering 20.18 27.63 30.8 47.58 24.24 30.09 35.06 31.34

@mohanarpit mohanarpit merged commit caca413 into release Feb 1, 2022
@mohanarpit mohanarpit deleted the fix/edge-cases-in-private-widgets branch February 1, 2022 05:18
@somangshu somangshu mentioned this pull request Feb 1, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabhrathod01 rishabhrathod01 rishabhrathod01 approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: List widget does not support rating widget properly.
3 participants
@ohansFavour @rishabhrathod01 @mohanarpit