Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: moustache+quotes formatting goes wrong in graphql body | autocomplete fail #16702

Closed
1 task done
rohan-arthur opened this issue Sep 12, 2022 · 1 comment · Fixed by #17229
Closed
1 task done

[Bug]: moustache+quotes formatting goes wrong in graphql body | autocomplete fail #16702

rohan-arthur opened this issue Sep 12, 2022 · 1 comment · Fixed by #17229
Assignees
@AmanAgarwal041
Labels
Bug Something isn't working GraphQL Plugin Issues related to GraphQL plugin Integrations Product Issues related to a specific integration Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Query & JS Pod Issues related to the query & JS Pod Verified When issue is retested post its fixed

Comments

@rohan-arthur
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

https://www.loom.com/share/ccf9fccc89064ee7b4230aaf5bf3cc52

  1. pairing of moustache brackets and quotes "" causes a parse error (red highlight, no error)
  2. after this error, autocomplete does not work anymore

Steps To Reproduce

see video

Public Sample App

No response

Version

Release
@rohan-arthur rohan-arthur added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage GraphQL Plugin Issues related to GraphQL plugin Medium Issues that frustrate users due to poor UX labels Sep 12, 2022
@github-actions github-actions bot added the Integrations Product Issues related to a specific integration label Sep 12, 2022
@AmanAgarwal041
Copy link
Contributor

Created another issue for highlighting error #17193

@AmanAgarwal041 AmanAgarwal041 mentioned this issue Sep 30, 2022
Merged
7 tasks
@close-label close-label bot added the QA Needs QA attention label Oct 8, 2022
@github-actions github-actions bot added the Query & JS Pod Issues related to the query & JS Pod label Oct 8, 2022
@prapullac prapullac added Verified When issue is retested post its fixed and removed QA Needs QA attention labels Oct 9, 2022
@sneha122 sneha122 mentioned this issue Aug 9, 2024
Merged
2 tasks
sneha122 added a commit that referenced this issue Aug 14, 2024
@sneha122
test: fixed skipped graphQL test (#35571)
37b5225 
## Description

**Context:**
This cypress test is asserting the fixes made for
[bug](#16702)
Bug recording:
https://www.loom.com/share/ccf9fccc89064ee7b4230aaf5bf3cc52

Basically bug was that when using bindings inside query of graphQL API,
autocomplete menu shows up for first binding, but not for second
binding. This test case asserts that autocomplete menu shows up every
time inside binding for query

EE PR: appsmithorg/appsmith-ee#4856

This PR fixes the skipped test of spec file:
cypress/e2e/Regression/ClientSide/BugTests/GraphQL_Binding_Bug16702_Spec.ts


Fixes #35147 
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10383572807>
> Commit: 0a655d7
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10383572807&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource`
> Spec:
> <hr>Wed, 14 Aug 2024 09:15:08 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


## Summary by CodeRabbit

- **Bug Fixes**
- Updated the test for a GraphQL binding issue, now actively validating
the resolution of a formatting bug that affected autocomplete
functionality.
- Enhanced test clarity by removing redundant code and optimizing the
test flow for improved execution efficiency.
- **Chores**
- Changed the focus of the limited test scenario to prioritize
addressing the GraphQL binding bug over template-related
functionalities.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AmanAgarwal041 AmanAgarwal041

Labels
Bug Something isn't working GraphQL Plugin Issues related to GraphQL plugin Integrations Product Issues related to a specific integration Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Query & JS Pod Issues related to the query & JS Pod Verified When issue is retested post its fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: adding mode for graphql syntax with dynamic bindings appsmithorg/appsmith
3 participants
@AmanAgarwal041 @prapullac @rohan-arthur