Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support for connecting via TLS to a managed Redis database #26723

Open
1 task done
felix-appsmith opened this issue Aug 28, 2023 · 13 comments
Open
1 task done
Assignees
Labels
Enhancement New feature or request Integrations Product Issues related to a specific integration Inviting Contribution Issues that we would like contributions to Query & JS Pod Issues related to the query & JS Pod Redis Issues related to Redis

Comments

@felix-appsmith
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Summary

The Appsmith Redis plugin currently allows you to connect to Redis instances that do not require the TLS protocol. For cases where it is explicitly necessary to connect via TLS, the plugin does not allow the connection and generates an error message saying Unexpected end of stream.

bee545eb17a0d564dd1f03c54c346f3e0a7745e1

Why should this be worked on?

It is important that this new feature is worked on, since there are currently services like DigitalOcean that require connection through TLS to access resources like Database Clusters. In this case, the official DigitalOcean documentation specifies that to connect remotely to a managed Redis database, it is necessary to do so using TLS.

@felix-appsmith felix-appsmith added the Enhancement New feature or request label Aug 28, 2023
@ame-appsmith ame-appsmith added the Redis Issues related to Redis label Dec 31, 2023
@ame-appsmith
Copy link

Another user requested this feature.

@github-actions github-actions bot added the Integrations Product Issues related to a specific integration label Dec 31, 2023
@Abhay-011
Copy link

Hi @Nikhil-Nandagopal,

I am encountering an issue with connecting Redis to Appsmith due to the inability to configure the TLS protocol. This is a significant blocker for our current development, which heavily relies on the Redis plugin in Appsmith.

Could you please provide any support or updates on this issue? Resolving this would greatly assist our ongoing projects.

Thank you for your help.

@Nikhil-Nandagopal
Copy link
Contributor

Nikhil-Nandagopal commented Jun 24, 2024

@Abhay-011 could you tell us a bit about your use case? We're currently help up with multiple feature requests and I'm not sure when we will get to this. One suggestion I have would be to write an API for the redis datasource and have Appsmith integrate with that API

@Nikhil-Nandagopal Nikhil-Nandagopal added the Query & JS Pod Issues related to the query & JS Pod label Aug 6, 2024
@andreaziz
Copy link

I have same problem here. I need to connect a redis with TLS enabled.

@Nikhil-Nandagopal Nikhil-Nandagopal added the Inviting Contribution Issues that we would like contributions to label Aug 12, 2024
@AnnaHariprasad5123
Copy link
Contributor

HI @Nikhil-Nandagopal, I am willing to work on this.

@NilanshBansal
Copy link
Contributor

NilanshBansal commented Oct 21, 2024

@AnnaHariprasad5123 please go ahead. Let us know if you need any clarifications/designs etc.
cc: @Nikhil-Nandagopal @rohan-arthur @carinanfonseca @appsmithorg/query-js-pod

@AnnaHariprasad5123
Copy link
Contributor

Hi @Nilansh Bansal, Good morning.

For Redis-tls, Is this design ok?
image
I followed the ui of redis-insight.

@NilanshBansal
Copy link
Contributor

@AnnaHariprasad5123 I believe there would be some changes to the UI design as per Appsmith's UI/UX guidelines. I can confirm this with our product designer @carinanfonseca and let you know but until then you can proceed with the above design similar to one of redis-insight and add the functional code. We will share you the updated designs in a few days until then you can work on the functionality and raise a PR.

cc: @rohan-arthur @carinanfonseca @appsmithorg/query-js-pod

@NilanshBansal
Copy link
Contributor

Hey @AnnaHariprasad5123 can you commit the UI changes in a draft PR? We want to generate a DP on the same and get it reviewed by @carinanfonseca.

@AnnaHariprasad5123
Copy link
Contributor

Hi @NilanshBansal, Could you check that.

@NilanshBansal
Copy link
Contributor

@carinanfonseca here is the DP with the UI changes. Can you please verify the designs here 🙏

@carinanfonseca
Copy link
Contributor

@AnnaHariprasad5123, first of all, thank you so much for your contribution. The experience you implemented aligns well with what we have in other data sources, so we should move forward with it.

@AnnaHariprasad5123
Copy link
Contributor

Hi @NilanshBansal, Could you check the pr.

NilanshBansal added a commit that referenced this issue Nov 5, 2024
…github.com:AnnaHariprasad5123/appsmith into chore/external-contribution-37106
@NilanshBansal NilanshBansal self-assigned this Nov 18, 2024
NilanshBansal added a commit that referenced this issue Nov 18, 2024
…github.com:AnnaHariprasad5123/appsmith into chore/external-contribution-37106
NilanshBansal added a commit that referenced this issue Nov 19, 2024
…github.com:AnnaHariprasad5123/appsmith into chore/external-contribution-37106
NilanshBansal added a commit that referenced this issue Nov 19, 2024
…github.com:AnnaHariprasad5123/appsmith into chore/external-contribution-37106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Integrations Product Issues related to a specific integration Inviting Contribution Issues that we would like contributions to Query & JS Pod Issues related to the query & JS Pod Redis Issues related to Redis
Projects
None yet
10 participants