Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: App title drop down pop up is not getting closed automatically when user opens up omnibar using hotkeys #28114

Closed
1 task done
ghost opened this issue Oct 16, 2023 · 7 comments · Fixed by #36504
Closed
1 task done

[Bug]: App title drop down pop up is not getting closed automatically when user opens up omnibar using hotkeys #28114

ghost opened this issue Oct 16, 2023 · 7 comments · Fixed by #36504
Assignees
@alex-golovanov @kocharrahul7 @rohan-arthur
Labels
Bug Something isn't working IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Inviting Contribution Issues that we would like contributions to Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Page Management Issues related to configuring pages Production

Comments

@ghost
Copy link

ghost commented Oct 16, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Description

screen shot :
image

Steps To Reproduce

  1. Expand app title drop down
  2. then from keyboard press ctrl+k to open omnibar pop up

Work around : Expands app title drop down then click on omnibar without using hot keys

Public Sample App

No response

Environment

Production

Issue video log

No response

Version

Appsmith v1.9.40-SNAPSHOT
@ghost ghost added Bug Something isn't working Page Management Issues related to configuring pages Low An issue that is neither critical nor breaks a user flow Production Needs Triaging Needs attention from maintainers to triage labels Oct 16, 2023
@github-actions github-actions bot added the UI Building Product Issues related to the UI Building experience label Oct 16, 2023
@yashnirmal
Copy link

Can I work on this one?

@Shree0310
Copy link

Hi, @Nikhil-Nandagopal will it be possible for you to assign this to me?

@Nikhil-Nandagopal
Copy link
Contributor

@Shree0310 you can pick it up.

@Shree0310
Copy link

@rajatagrawal here's the issue assigned to me. Currently I am going through https://github.com/appsmithorg/appsmith/blob/master/contributions/ClientSetup.md

@rajatagrawal
Copy link
Contributor

@Shree0310

Can you please paste screenshot/logs of the error that you are facing so that I can understand the problem that you are facing ?

@Nikhil-Nandagopal Nikhil-Nandagopal removed the UI Building Product Issues related to the UI Building experience label Mar 6, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added the IDE Pod Issues that new developers face while exploring the IDE label Aug 5, 2024
@github-actions github-actions bot removed the IDE Pod Issues that new developers face while exploring the IDE label Aug 5, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product and removed IDE Pod labels Aug 5, 2024
@rohan-arthur rohan-arthur added the Inviting Contribution Issues that we would like contributions to label Aug 29, 2024
@saicharan-zemoso
Copy link
Contributor

Hello @rohan-arthur , I am picking this issue.

@rohan-arthur
Copy link
Contributor

@saicharan-zemoso awesome, and thank you!

@saicharan-zemoso saicharan-zemoso mentioned this issue Sep 24, 2024
Merged
@alex-golovanov alex-golovanov self-assigned this Oct 8, 2024
@alex-golovanov alex-golovanov mentioned this issue Oct 9, 2024
Closed
2 tasks
KelvinOm pushed a commit that referenced this issue Oct 9, 2024
@saicharan-zemoso
fix: App title drop down close on interaction with other components. (#…
4c58a98 
…36504)

Fixes #28114 

fixed the app title drop down and it closes on interaction with other
components

Before fixing the bug the omni bar and title dropdown overlap over each
other:

![image](https://github.com/user-attachments/assets/36fc6b26-9222-4fb9-b97a-d39a9b249403)

after the fix the app title drop down closes on opening omni bar or any
other component.

added the cypress test to visually confirm that the fix was working and
did not add unit test as to test this we need to interact with other
components or open omni bar while testing.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced the Navigation Menu to automatically close when users
interact outside of it, improving user experience.
- Introduced a test suite for validating application dropdown
interactions with the omnibar using keyboard shortcuts.

- **Bug Fixes**
- Resolved an issue where the dropdown menu would remain open after
interactions outside its boundaries.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-golovanov alex-golovanov

@kocharrahul7 kocharrahul7

@rohan-arthur rohan-arthur

Labels
Bug Something isn't working IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Inviting Contribution Issues that we would like contributions to Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Page Management Issues related to configuring pages Production
Projects
None yet
Milestone
No milestone
10 participants
@alex-golovanov @rajatagrawal @Nikhil-Nandagopal @natashaooh @pranavkanade @kocharrahul7 @yashnirmal @rohan-arthur @saicharan-zemoso @Shree0310