Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Uncommitted changes are present on all existing git connected apps #35536

Closed
1 task done
laveena-en opened this issue Aug 8, 2024 · 0 comments · Fixed by #35554
Closed
1 task done

[Bug]: Uncommitted changes are present on all existing git connected apps #35536

laveena-en opened this issue Aug 8, 2024 · 0 comments · Fixed by #35554
Assignees
@nidhi-nair @brayn003
Labels
Bug Something isn't working Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention Release Blocker This issue must be resolved before the release

Comments

@laveena-en
Copy link
Contributor

laveena-en commented Aug 8, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Description

Uncommitted changes are present on all existing git connected apps

Steps To Reproduce

  1. Open any existing git connected app and notice that there's an uncommitted change
    image

You can see these changes in the below app:
App: https://nightly-saml-alb-https.appsmith.com/app/may6-test-ee/page1-6639e27e537e5d6089eb03ec?branch=test_bug
Repo: https://github.com/laveena-en/may6-test-ee

I've branched off from main to branch test_bug to find the diff as shown below
image

Public Sample App

No response

Environment

Production

Severity

High (Blocker to building or releasing)

Issue video log

No response

Version

Cloud
@laveena-en laveena-en added Bug Something isn't working Production Needs Triaging Needs attention from maintainers to triage Git Product Issues related to version control product Release Blocker This issue must be resolved before the release labels Aug 8, 2024
@github-actions github-actions bot removed the Git Product Issues related to version control product label Aug 8, 2024
@sondermanish sondermanish mentioned this issue Aug 8, 2024
Merged
2 tasks
@appsmith-bot appsmith-bot added the QA Needs QA attention label Aug 9, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label Aug 9, 2024
sondermanish added a commit that referenced this issue Aug 9, 2024
@sondermanish
fix: added an autocommit migration for theme settings. (#35554)
032cd33 
## Description
> 
>
>

Fixes #35536

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10315694999>
> Commit: f03353b
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10315694999&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Fri, 09 Aug 2024 08:16:04 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced migration logic for server schema versions, ensuring proper
handling of theme settings during migrations from version 6 to 9.
- Introduced methods to establish and set default theme settings for
applications during migration.

- **Bug Fixes**
- Simplified server version retrieval process, ensuring consistent
versioning behavior.

- **Tests**
- Updated tests to reflect changes in server version expectations,
removing unnecessary assertions related to feature flags.
- Streamlined validation logic in migration tests to focus solely on
expected schema versions.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nidhi-nair nidhi-nair

@brayn003 brayn003

Labels
Bug Something isn't working Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention Release Blocker This issue must be resolved before the release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: added an autocommit migration for theme settings. appsmithorg/appsmith
4 participants
@nidhi-nair @brayn003 @appsmith-bot @laveena-en