Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Update the editable text component for Action names on action editor #36793

Closed
Tracked by #34663
ankitakinger opened this issue Oct 10, 2024 · 0 comments · Fixed by #36960
Closed
Tracked by #34663

[Task]: Update the editable text component for Action names on action editor #36793

ankitakinger opened this issue Oct 10, 2024 · 0 comments · Fixed by #36960
Assignees
@ankitakinger
Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo

Comments

@ankitakinger
Copy link
Contributor

SubTasks

This needs to be done under the new modularised flow, and not the old flow, to match the designs.
@ankitakinger ankitakinger added IDE Product Issues related to the IDE Product Task A simple Todo IDE Pod Issues that new developers face while exploring the IDE labels Oct 10, 2024
@ankitakinger ankitakinger self-assigned this Oct 10, 2024
This was referenced Oct 16, 2024
Open
Merged
Closed
ankitakinger added a commit that referenced this issue Oct 18, 2024
@ankitakinger
chore: Updating plugin action name editor component to use ADS text c…
9a315ea 
…omponent (#36960)

## Description

Updating plugin action name editor component to use ADS text component
instead of EditableText from blueprint. Also, adding permission checks
for editable tabs to not allow the name edits when the user doesn't have
the permission.

Fixes [#36793](#36793)

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11402567877>
> Commit: 0b695e8
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11402567877&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Fri, 18 Oct 2024 12:36:26 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced conditional editing functionality in the FileTab component
based on user permissions.
- Enhanced the PluginActionNameEditor with real-time validation and
improved user interaction.
- Added user permissions information to entity items and selectors for
better access control.
- Integrated new functionality for saving entity names and managing
editable tab permissions.
- Expanded the EditorTabs component to include contextual entity
information for each tab.

- **Bug Fixes**
- Simplified the ActionNameEditor by removing unnecessary feature flag
checks.

- **Documentation**
- Updated interfaces and components to improve clarity and
functionality.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@coderabbitai coderabbitai bot mentioned this issue Oct 22, 2024
Merged
2 tasks
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this issue Nov 20, 2024
@ankitakinger
chore: Updating plugin action name editor component to use ADS text c…
ded695e 
…omponent (appsmithorg#36960)

## Description

Updating plugin action name editor component to use ADS text component
instead of EditableText from blueprint. Also, adding permission checks
for editable tabs to not allow the name edits when the user doesn't have
the permission.

Fixes [appsmithorg#36793](appsmithorg#36793)

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11402567877>
> Commit: 0b695e8
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11402567877&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Fri, 18 Oct 2024 12:36:26 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced conditional editing functionality in the FileTab component
based on user permissions.
- Enhanced the PluginActionNameEditor with real-time validation and
improved user interaction.
- Added user permissions information to entity items and selectors for
better access control.
- Integrated new functionality for saving entity names and managing
editable tab permissions.
- Expanded the EditorTabs component to include contextual entity
information for each tab.

- **Bug Fixes**
- Simplified the ActionNameEditor by removing unnecessary feature flag
checks.

- **Documentation**
- Updated interfaces and components to improve clarity and
functionality.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankitakinger ankitakinger

Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Updating plugin action name editor component to use ADS text component appsmithorg/appsmith
1 participant
@ankitakinger