Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix query tab scrollbar position #38135

Closed
KelvinOm opened this issue Dec 12, 2024 · 0 comments · Fixed by #38317 or #38380
Closed

Fix query tab scrollbar position #38135

KelvinOm opened this issue Dec 12, 2024 · 0 comments · Fixed by #38317 or #38380
Assignees
@alex-golovanov
Labels
Bug Something isn't working IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Low An issue that is neither critical nor breaks a user flow QA Pod Issues under the QA Pod QA Needs QA attention Task A simple Todo

Comments

@KelvinOm
Copy link
Collaborator

KelvinOm commented Dec 12, 2024 •
edited
Loading

Снимок экрана 2024-12-12 в 16 32 28
@KelvinOm KelvinOm added Bug Something isn't working IDE Product Issues related to the IDE Product Task A simple Todo labels Dec 12, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added the Low An issue that is neither critical nor breaks a user flow label Dec 12, 2024
@github-actions github-actions bot added the IDE Pod Issues that new developers face while exploring the IDE label Dec 12, 2024
@alex-golovanov alex-golovanov mentioned this issue Dec 23, 2024
Merged
2 tasks
alex-golovanov added a commit that referenced this issue Dec 25, 2024
@alex-golovanov
fix: query tab scrollbar padding gap fix (#38317)
0c1a1d8 
## Description
Remove scrollbar gap in request config.


Fixes [#38135](#38135)

## Automation

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]
> 🟣 🟣 🟣 Your tests are running.
> Tests running at:
<https://github.com/appsmithorg/appsmith/actions/runs/12491071853>
> Commit: 85399db
> Workflow: `PR Automation test suite`
> Tags: `@tag.IDE`
> Spec: ``
> <hr>Wed, 25 Dec 2024 08:14:00 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a tabbed interface in the `CommonEditorForm` for better
content organization.
- Enhanced usability of the `PluginActionForm` with scrollable content
areas.
  
- **Bug Fixes**
- Adjusted tooltip positioning to improve visibility in the
`EmbeddedDatasourcePathField`.

- **Style**
- Added new styled components for tabs and headers to enhance layout and
design.

- **Chores**
- Deprecated the `RequestTabs` component in preparation for its removal.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@appsmith-bot appsmith-bot added the QA Needs QA attention label Dec 25, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label Dec 25, 2024
This was referenced Dec 25, 2024
Closed
Merged
sagar-qa007 pushed a commit that referenced this issue Dec 27, 2024
@alex-golovanov
fix: fix url evaluation (#38380)
257828b 
## Description
Fixes API_Edit_spec.js

Fixes #38135 

## Automation

/ok-to-test tags="@tag.AccessControl"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12507336996>
> Commit: 7ff5552
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12507336996&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.AccessControl`
> Spec:
> <hr>Thu, 26 Dec 2024 21:27:58 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Adjusted the test case for URL field interaction by removing the Enter
key action after clicking, streamlining the validation process.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
NandanAnantharamu pushed a commit that referenced this issue Dec 27, 2024
@alex-golovanov
fix: query tab scrollbar padding gap fix (#38317)
c0c9747 
## Description
Remove scrollbar gap in request config.


Fixes [#38135](#38135)

## Automation

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]
> 🟣 🟣 🟣 Your tests are running.
> Tests running at:
<https://github.com/appsmithorg/appsmith/actions/runs/12491071853>
> Commit: 85399db
> Workflow: `PR Automation test suite`
> Tags: `@tag.IDE`
> Spec: ``
> <hr>Wed, 25 Dec 2024 08:14:00 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a tabbed interface in the `CommonEditorForm` for better
content organization.
- Enhanced usability of the `PluginActionForm` with scrollable content
areas.
  
- **Bug Fixes**
- Adjusted tooltip positioning to improve visibility in the
`EmbeddedDatasourcePathField`.

- **Style**
- Added new styled components for tabs and headers to enhance layout and
design.

- **Chores**
- Deprecated the `RequestTabs` component in preparation for its removal.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
NandanAnantharamu pushed a commit that referenced this issue Dec 27, 2024
@alex-golovanov
fix: fix url evaluation (#38380)
d3f9b5d 
## Description
Fixes API_Edit_spec.js

Fixes #38135 

## Automation

/ok-to-test tags="@tag.AccessControl"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12507336996>
> Commit: 7ff5552
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12507336996&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.AccessControl`
> Spec:
> <hr>Thu, 26 Dec 2024 21:27:58 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Adjusted the test case for URL field interaction by removing the Enter
key action after clicking, streamlining the validation process.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this issue Feb 7, 2025
@alex-golovanov
fix: query tab scrollbar padding gap fix (appsmithorg#38317)
1d0c339 
## Description
Remove scrollbar gap in request config.


Fixes [appsmithorg#38135](appsmithorg#38135)

## Automation

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]
> 🟣 🟣 🟣 Your tests are running.
> Tests running at:
<https://github.com/appsmithorg/appsmith/actions/runs/12491071853>
> Commit: 85399db
> Workflow: `PR Automation test suite`
> Tags: `@tag.IDE`
> Spec: ``
> <hr>Wed, 25 Dec 2024 08:14:00 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a tabbed interface in the `CommonEditorForm` for better
content organization.
- Enhanced usability of the `PluginActionForm` with scrollable content
areas.
  
- **Bug Fixes**
- Adjusted tooltip positioning to improve visibility in the
`EmbeddedDatasourcePathField`.

- **Style**
- Added new styled components for tabs and headers to enhance layout and
design.

- **Chores**
- Deprecated the `RequestTabs` component in preparation for its removal.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this issue Feb 7, 2025
@alex-golovanov
fix: fix url evaluation (appsmithorg#38380)
ef3d6c2 
## Description
Fixes API_Edit_spec.js

Fixes appsmithorg#38135 

## Automation

/ok-to-test tags="@tag.AccessControl"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12507336996>
> Commit: 7ff5552
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12507336996&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.AccessControl`
> Spec:
> <hr>Thu, 26 Dec 2024 21:27:58 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Adjusted the test case for URL field interaction by removing the Enter
key action after clicking, streamlining the validation process.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-golovanov alex-golovanov

Labels
Bug Something isn't working IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Low An issue that is neither critical nor breaks a user flow QA Pod Issues under the QA Pod QA Needs QA attention Task A simple Todo
Projects
None yet
Milestone
No milestone
4 participants
@alex-golovanov @Nikhil-Nandagopal @KelvinOm @appsmith-bot