-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding Tenant Information to Redis Cache for quick fetch #33641
Merged
NilanshBansal
merged 43 commits into
release
from
feature/issue-33083/tenant-config-to-redis
May 28, 2024
Merged
feat: Adding Tenant Information to Redis Cache for quick fetch #33641
NilanshBansal
merged 43 commits into
release
from
feature/issue-33083/tenant-config-to-redis
May 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ervices/ce/TenantServiceCEImpl.java Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
…g-to-redis' into feature/issue-33083/tenant-config-to-redis
…e/issue-33083/tenant-config-to-redis
This reverts commit da5af58.
…e/issue-33083/tenant-config-to-redis
…om:appsmithorg/appsmith into feature/issue-33083/tenant-config-to-redis
All tests have passed earlier before this commit. Running only a subset of tests now as the change is only done to a server unit test file. |
abhvsn
approved these changes
May 27, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Enhancement
New feature or request
Integrations Pod General
Issues related to the Integrations Pod that don't fit into other tags.
Integrations Product
Issues related to a specific integration
ok-to-test
Required label for CI
Task
A simple Todo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tenant is fetched multiple times across the appsmith codebase but is rarely updated (from the admin settings). Every time a fetch call to the database is costly both in terms of resources and time taken.
The consolidated api also makes a call to fetch the tenant and return to the client. To improve the performance of fetching the tenant information, we are moving the tenant information to redis cache for quicker fetch.
This will improve the performance of the consolidated api and also reduce the time taken by all the different functionalities within the backend codebase which depend on tenant to process further.
Counterpart EE PR: https://github.com/appsmithorg/appsmith-ee/pull/4275
TL;DR
Adds tenant information
tenantService.getDefaultTenant()
to redis.Fixes #33083, #33504, #33578
Automation
/ok-to-test tags="@tag.Settings"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9253953003
Commit: 7b4bf8d
Cypress dashboard url: Click here!
Communication
Should the DevRel and Marketing teams inform users about this change?