feat: remove-clear-option-for-required-select-widget #35060

AnnaHariprasad5123 · 2024-07-22T06:25:16Z

Hi @rohan-arthur, @somangshu , @contributor-support

Fixes #34262

What's in this pr :

Added isRequired prop for select widget components to control the logic for the remove button.
Added two test cases to verify clear button rendering when isRequired is set to true and false.

Screenshots :

Please let me know if any changes are required.

Thank you.

Summary by CodeRabbit

New Features
- Introduced an isRequired property to the SelectButton, SelectComponent, and SelectWidget, allowing users to indicate whether a selection is mandatory.
- Enhanced rendering logic in the SelectButton to conditionally display the cancel button based on the isRequired state.
- Improved styling and behavior options in SelectComponent for better integration into forms.
Tests
- Added new test cases for the SelectButton to ensure correct rendering behavior of the cancel button based on the isRequired prop.
- Streamlined Cypress tests to focus on the non-existence of the clear button, reflecting updated component behavior.
- Updated locator configurations to improve test coverage for user interactions involving clearing selections.

coderabbitai · 2024-07-22T06:25:30Z

Walkthrough

The recent changes enhance the SelectButton and SelectWidget components by introducing a new optional isRequired property. This property controls the rendering of the cancel button, ensuring it is absent when a selection is mandatory. Additionally, the modifications improve validation capabilities in forms, reinforcing that required selections cannot be cleared, thereby aligning with the objectives outlined in issue #34262.

Changes

Files	Change Summary
`app/client/src/widgets/SelectWidget/component/SelectButton.*`	Added `isRequired` prop to `SelectButtonProps`, affecting cancel button rendering logic and tests.
`app/client/src/widgets/SelectWidget/component/index.tsx`	Introduced `isRequired` to `SelectComponentProps` and passed it to `StyledSingleDropDown`.
`app/client/src/widgets/SelectWidget/widget/index.tsx`	Integrated `isRequired` into `SelectWidget`, enabling it to signify mandatory selections.
`app/client/cypress/e2e/Regression/ClientSide/Widgets/ListV2/...`	Simplified tests to check for the absence of the cancel button when required.
`app/client/cypress/e2e/Regression/ClientSide/Widgets/Select/...`	Adjusted tests to focus on the absence of the cancel button for required selections.

Assessment against linked issues

Objective	Addressed	Explanation
Enforce that the option to clear is removed when the select widget is required (#[34262])	✅
Ensure forms are submitted with valid information (#[34262])	✅

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 57decce and 91e37ba.

Files selected for processing (4)

app/client/src/widgets/SelectWidget/component/SelectButton.test.tsx (1 hunks)
app/client/src/widgets/SelectWidget/component/SelectButton.tsx (3 hunks)
app/client/src/widgets/SelectWidget/component/index.tsx (2 hunks)
app/client/src/widgets/SelectWidget/widget/index.tsx (1 hunks)

Additional comments not posted (7)

app/client/src/widgets/SelectWidget/component/SelectButton.tsx (2)

18-18: Property Addition Approved

The addition of the isRequired property to the SelectButtonProps interface is appropriate and aligns with the PR objectives.

32-32: Usage of isRequired Property Approved

The usage of the isRequired property in the destructured props and the rendering logic of the button is correct. It ensures that the cancel icon is not displayed when isRequired is true.

Also applies to: 43-43

app/client/src/widgets/SelectWidget/component/SelectButton.test.tsx (2)

62-68: Test Case for isRequired True Approved

The test case correctly verifies that the cancel button does not render when isRequired is true.

70-76: Test Case for isRequired False Approved

The test case correctly verifies that the cancel button renders when isRequired is false.

app/client/src/widgets/SelectWidget/component/index.tsx (2)

459-459: Property Addition Approved

The addition of the isRequired property to the SelectComponentProps interface is appropriate and aligns with the PR objectives.

432-432: Usage of isRequired Property Approved

The usage of the isRequired property in the SelectButton component within the SelectComponent class is correct. It ensures that the property is passed down appropriately.

app/client/src/widgets/SelectWidget/widget/index.tsx (1)

852-852: LGTM! Ensure isRequired property is correctly utilized.

The addition of the isRequired property to the SelectComponent is approved. Ensure that the SelectComponent properly handles the isRequired property to control the rendering behavior.

AnnaHariprasad5123 · 2024-07-25T03:52:02Z

HI @somangshu, Could you review this pr.

NilanshBansal · 2024-07-29T11:49:06Z

@appsmithorg/contributor-support can we get this reviewed.

github-actions · 2024-08-05T16:36:40Z

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

AnnaHariprasad5123 · 2024-08-08T01:49:32Z

Hi @somangshu, Could you please review this pr.

NilanshBansal · 2024-08-08T03:43:37Z

@rahulbarwal @jacquesikot can you please review this

rahulbarwal · 2024-08-09T04:24:39Z

@AnnaHariprasad5123 Client liniting is failing for changes in this PR

Logs
To check locally run yarn run lint:ci

AnnaHariprasad5123 · 2024-08-09T06:21:08Z

Hi @rahulbarwal, Could you check now. I fixed linting issues and pushed the changes.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 91e37ba and f19de93.

Files selected for processing (3)

app/client/src/widgets/SelectWidget/component/SelectButton.test.tsx (1 hunks)
app/client/src/widgets/SelectWidget/component/SelectButton.tsx (3 hunks)
app/client/src/widgets/SelectWidget/component/index.tsx (2 hunks)

Additional comments not posted (3)

app/client/src/widgets/SelectWidget/component/SelectButton.tsx (1)

18-18: LGTM! Ensure isRequired usage is consistent.

The addition of the isRequired property and its integration into the rendering logic is well-implemented. The logic correctly prevents the cancel icon from displaying when isRequired is true.

Verify that the isRequired property is used consistently across the codebase to avoid any discrepancies.

Also applies to: 28-28, 43-43

app/client/src/widgets/SelectWidget/component/SelectButton.test.tsx (1)

62-68: Test cases for isRequired property are well-implemented.

The added test cases effectively verify the conditional rendering of the cancel button based on the isRequired property. This enhances the robustness of the test suite.

Also applies to: 70-76
app/client/src/widgets/SelectWidget/component/index.tsx (1)
432-432: Enhancements to SelectComponentProps are well-structured.

The introduction of new properties, including isRequired, enhances the configurability and functionality of the SelectComponent. The changes align with the PR objectives and improve user experience.

Ensure that the integration of these new properties, particularly isRequired, is thoroughly tested and documented across the codebase.

Also applies to: 442-480

Verification successful

Integration of isRequired and Other Properties Verified

The search results indicate that the new properties, including isRequired, are integrated throughout the codebase. They appear in various contexts, such as component props, conditional checks, and styling. This suggests that the properties are well-integrated and likely tested.

Integration Points:

isRequired is used in prop assignments and conditional logic.

Other properties like accentColor, borderRadius, and boxShadow are also used extensively in styling and component configurations.

For thorough verification, ensure these properties are covered in unit tests and documented in the relevant parts of the codebase.
Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify integration and documentation of new properties in `SelectComponentProps`.

# Test: Search for the usage of new properties in the codebase. Expect: Proper integration and documentation.
rg --type tsx 'accentColor|borderRadius|boxShadow|compactMode|hasError|isRequired'
Length of output: 112

Script:
#!/bin/bash
# Description: Verify integration and documentation of new properties in `SelectComponentProps`.

# Find all .tsx files and search for the new properties within them.
fd --extension tsx --exec rg 'accentColor|borderRadius|boxShadow|compactMode|hasError|isRequired' {}
Length of output: 108273

AnnaHariprasad5123 · 2024-08-13T12:11:16Z

HI @rahulbarwal, Could you please review this pr.

rahulbarwal · 2024-08-14T12:06:57Z

@AnnaHariprasad5123 Sorry for the delay.
This PR still has a lint error: https://github.com/appsmithorg/appsmith/actions/runs/10387054014/job/28759692813?pr=35562#step:9:1743

Can you please fix it?

AnnaHariprasad5123 · 2024-08-14T12:38:38Z

Hi @rahulbarwal,

accentColor?: string;
  borderRadius: string;
  boxShadow?: string;
  className?: string;
  compactMode: boolean;
  disabled?: boolean;
  dropDownWidth: number;
  filterText?: string;
  hasError?: boolean;
  height: number;
  hideCancelIcon?: boolean;
  isDynamicHeightEnabled?: boolean;
  isFilterable: boolean;
  isLoading: boolean;
  isOpen?: boolean;
  isRequired?: boolean;
  isValid: boolean;
  label?: string | number;
  labelAlignment?: Alignment;
  labelPosition?: LabelPosition;
  labelStyle?: string;
  labelText: string;
  labelTextColor?: string;
  labelTextSize?: TextSize;
  labelTooltip?: string;
  labelWidth?: number;
  onClose?: () => void;
  onDropdownClose?: () => void;
  onDropdownOpen?: () => void;
  onFilterChange: (text: string) => void;
  onOptionSelected: (optionSelected: DropdownOption) => void;
  options: DropdownOption[];
  placeholder?: string;
  resetFilterTextOnClose?: boolean;
  rtl?: boolean;
  selectedIndex?: number;
  serverSideFiltering: boolean;
  value?: string | number;
  width: number;

I ordered them alphabetically in previous commit but still it is showing error as they are not ordered. Can you conform the order of these props.

rahulbarwal · 2024-08-15T05:56:01Z

@AnnaHariprasad5123 It is talking about this line.

AnnaHariprasad5123 · 2024-08-15T18:34:31Z

@rahulbarwal, Thanks for the info. Could you check now and let me know if any actions required from my end.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f19de93 and 9ba6b59.

Files selected for processing (1)

app/client/src/widgets/SelectWidget/component/index.tsx (2 hunks)

Additional comments not posted (3)

app/client/src/widgets/SelectWidget/component/index.tsx (3)

428-428: Correct usage of isRequired prop.

The isRequired prop is correctly passed to the StyledSingleDropDown component, aligning with the PR objectives to manage the visibility of the remove button based on this property.

442-480: New properties in SelectComponentProps are well-defined.

The new properties accentColor, borderRadius, boxShadow, compactMode, hasError, and isRequired are correctly defined with appropriate types. The rearrangement of properties maintains consistency and readability.

Line range hint 1-480:
Successful integration of enhancements.

The changes effectively enhance the SelectComponent by introducing new styling options and improving validation capabilities. These modifications align with the PR objectives, ensuring better integration into forms and an improved user experience.

AnnaHariprasad5123 · 2024-08-19T05:19:47Z

Hi @rahulbarwal,
Good morning, Can you check now.

rahulbarwal · 2024-08-19T05:29:08Z

@AnnaHariprasad5123 On cypress CI, some other select related specs are failing. Please checkout description of this PR: #35562

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9ba6b59 and 2e59a1d.

Files selected for processing (2)

app/client/cypress/e2e/Regression/ClientSide/Widgets/ListV2/Childwigets/List_Select_Widgets_spec.js (1 hunks)
app/client/cypress/e2e/Regression/ClientSide/Widgets/Select/Select2_Spec.ts (1 hunks)

Additional context used

Path-based instructions (2)

app/client/cypress/e2e/Regression/ClientSide/Widgets/ListV2/Childwigets/List_Select_Widgets_spec.js (1)

Pattern app/client/cypress/**/**.*:

app/client/cypress/e2e/Regression/ClientSide/Widgets/Select/Select2_Spec.ts (1)

Pattern app/client/cypress/**/**.*:

Additional comments not posted (2)

app/client/cypress/e2e/Regression/ClientSide/Widgets/ListV2/Childwigets/List_Select_Widgets_spec.js (1)

152-152: LGTM! Test case correctly verifies the absence of the cancel button.

The assertion ensures that the cancel button does not exist when the select widget is marked as required, aligning with the PR objectives.

app/client/cypress/e2e/Regression/ClientSide/Widgets/Select/Select2_Spec.ts (1)

300-300: LGTM! Test case correctly verifies the absence of the cancel button.

The assertion ensures that the cancel button does not exist when the select widget is marked as required, aligning with the PR objectives.

AnnaHariprasad5123 · 2024-08-19T12:08:11Z

Hi @rahulbarwal, Could you check now.

cypress/e2e/Regression/ClientSide/Binding/Api_withPageload_Input_spec.js
It is due to docker url.
cypress/e2e/Regression/ClientSide/Widgets/ListV2/Childwigets/List_Select_Widgets_spec.js
cypress/e2e/Regression/ClientSide/Widgets/Select/Select2_Spec.ts

AnnaHariprasad5123 · 2024-08-19T12:19:30Z

Hi @rahulbarwal, check once.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2e59a1d and bc182d1.

Files selected for processing (3)

app/client/cypress/e2e/Regression/ClientSide/Widgets/ListV2/Childwigets/List_Select_Widgets_spec.js (1 hunks)
app/client/cypress/e2e/Regression/ClientSide/Widgets/Select/Select2_Spec.ts (2 hunks)
app/client/cypress/locators/commonlocators.json (1 hunks)

Files skipped from review as they are similar to previous changes (2)

app/client/cypress/e2e/Regression/ClientSide/Widgets/ListV2/Childwigets/List_Select_Widgets_spec.js
app/client/cypress/e2e/Regression/ClientSide/Widgets/Select/Select2_Spec.ts

Additional context used

Path-based instructions (1)

app/client/cypress/locators/commonlocators.json (1)

Pattern app/client/cypress/**/**.*:

Additional comments not posted (1)

app/client/cypress/locators/commonlocators.json (1)

76-76: Addition of selectClearButton locator looks good!

The new locator "selectClearButton": "selectbutton.btn.cancel" has been added correctly. Ensure that the CSS selector accurately targets the intended element in the application's DOM.

app/client/cypress/locators/commonlocators.json

app/client/src/widgets/SelectWidget/component/SelectButton.test.tsx

AnnaHariprasad5123 · 2024-08-20T02:51:11Z

HI @rahulbarwal, Could you check now.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bc182d1 and b41fbe8.

Files selected for processing (3)

app/client/cypress/e2e/Regression/ClientSide/Widgets/Select/Select2_Spec.ts (2 hunks)
app/client/cypress/locators/commonlocators.json (1 hunks)
app/client/src/widgets/SelectWidget/component/SelectButton.test.tsx (2 hunks)

Files skipped from review as they are similar to previous changes (3)

app/client/cypress/e2e/Regression/ClientSide/Widgets/Select/Select2_Spec.ts
app/client/cypress/locators/commonlocators.json
app/client/src/widgets/SelectWidget/component/SelectButton.test.tsx

app/client/cypress/locators/commonlocators.json

AnnaHariprasad5123 · 2024-08-20T08:23:48Z

HI @rahulbarwal, I done as you said. Can you check now.

coderabbitai

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b41fbe8 and 99640bf.

Files selected for processing (4)

app/client/cypress/e2e/Regression/ClientSide/Widgets/ListV2/Childwigets/List_Select_Widgets_spec.js (2 hunks)
app/client/cypress/e2e/Regression/ClientSide/Widgets/Select/Select2_Spec.ts (2 hunks)
app/client/cypress/support/Objects/CommonLocators.ts (1 hunks)
app/client/src/widgets/SelectWidget/component/SelectButton.test.tsx (3 hunks)

Files skipped from review as they are similar to previous changes (2)

app/client/cypress/e2e/Regression/ClientSide/Widgets/ListV2/Childwigets/List_Select_Widgets_spec.js
app/client/src/widgets/SelectWidget/component/SelectButton.test.tsx

Additional context used

Path-based instructions (2)

app/client/cypress/e2e/Regression/ClientSide/Widgets/Select/Select2_Spec.ts (1)

Pattern app/client/cypress/**/**.*:

app/client/cypress/support/Objects/CommonLocators.ts (1)

Pattern app/client/cypress/**/**.*:

Biome

app/client/cypress/e2e/Regression/ClientSide/Widgets/Select/Select2_Spec.ts

[error] 17-17: Shouldn't redeclare 'locators'. Consider to delete it or rename it.

'locators' is defined here:

(lint/suspicious/noRedeclare)

Additional comments not posted (2)

app/client/cypress/e2e/Regression/ClientSide/Widgets/Select/Select2_Spec.ts (1)

304-304: Simplified test case looks good.

The test case has been simplified to check for the absence of the clear button, aligning with the new isRequired property functionality.

app/client/cypress/support/Objects/CommonLocators.ts (1)

337-338: Addition of test IDs is appropriate.

The new properties _selectClearButton_testId and _selectClearButton_dataTestId enhance the testability of the select widget by providing specific identifiers.

app/client/cypress/e2e/Regression/ClientSide/Widgets/Select/Select2_Spec.ts

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 99640bf and 92f3d2a.

Files selected for processing (1)

app/client/cypress/e2e/Regression/ClientSide/Widgets/Select/Select2_Spec.ts (2 hunks)

Files skipped from review as they are similar to previous changes (1)

app/client/cypress/e2e/Regression/ClientSide/Widgets/Select/Select2_Spec.ts

app/client/cypress/e2e/Regression/ClientSide/Widgets/Select/Select2_Spec.ts

...ent/cypress/e2e/Regression/ClientSide/Widgets/ListV2/Childwigets/List_Select_Widgets_spec.js

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 92f3d2a and 29a20a6.

Files selected for processing (2)

app/client/cypress/e2e/Regression/ClientSide/Widgets/ListV2/Childwigets/List_Select_Widgets_spec.js (1 hunks)
app/client/cypress/e2e/Regression/ClientSide/Widgets/Select/Select2_Spec.ts (1 hunks)

Files skipped from review due to trivial changes (1)

app/client/cypress/e2e/Regression/ClientSide/Widgets/ListV2/Childwigets/List_Select_Widgets_spec.js

Files skipped from review as they are similar to previous changes (1)

app/client/cypress/e2e/Regression/ClientSide/Widgets/Select/Select2_Spec.ts

rahulbarwal

Looks good. Thanks for your effort and your patience :) @AnnaHariprasad5123
Waiting for CI to pass here: #35562

rahulbarwal · 2024-08-20T10:22:47Z

@sagar-qa007 Please review cypress changes here.

rahulbarwal · 2024-08-22T09:43:24Z

@AnnaHariprasad5123 we have some failures here: #35562

Please check if they are related to your changes(check description).

AnnaHariprasad5123 · 2024-08-23T02:25:45Z

Hi @rahulbarwal, Good morning

1. cypress/e2e/Regression/ClientSide/OtherUIFeatures/GlobalSearch_spec.js : It is failed while setuping the postgres datasource with "host.docker.internal" host address.

2. cypress/e2e/Regression/ServerSide/QueryPane/S3_2_spec.ts : It is failed while setuping the S3 datasource.

These things are not related to select widget.

rahulbarwal · 2024-08-23T04:52:53Z

Seems unrelated, thanks for taking a look. I've triggered another run, I'll monitor it.

AnnaHariprasad5123 · 2024-08-28T09:15:03Z

Hi @rahulbarwal, If everthing is ok, Can you merge this pr.

feat: remove-clear-option-for-required-select-widget

91e37ba

coderabbitai bot reviewed Jul 22, 2024

View reviewed changes

github-actions bot added the Stale label Aug 5, 2024

NilanshBansal removed the Stale label Aug 8, 2024

NilanshBansal requested review from rahulbarwal and jacquesikot August 8, 2024 03:44

rahulbarwal mentioned this pull request Aug 9, 2024

chore: external merge request from Contributor #35562

Closed

2 tasks

fix-client-linting-issues

f19de93

coderabbitai bot reviewed Aug 9, 2024

View reviewed changes

fix-isRequired-prop-order

9ba6b59

coderabbitai bot reviewed Aug 15, 2024

View reviewed changes

fix-cypress-tests

2e59a1d

AnnaHariprasad5123 requested review from ApekshaBhosale and sagar-qa007 as code owners August 19, 2024 12:04

coderabbitai bot reviewed Aug 19, 2024

View reviewed changes

added-locator-variable

bc182d1

coderabbitai bot reviewed Aug 19, 2024

View reviewed changes

rahulbarwal reviewed Aug 19, 2024

View reviewed changes

app/client/cypress/locators/commonlocators.json Outdated Show resolved Hide resolved

rahulbarwal requested changes Aug 19, 2024

View reviewed changes

app/client/src/widgets/SelectWidget/component/SelectButton.test.tsx Outdated Show resolved Hide resolved

app/client/src/widgets/SelectWidget/component/SelectButton.test.tsx Outdated Show resolved Hide resolved

modified-common-locator

b41fbe8

coderabbitai bot reviewed Aug 20, 2024

View reviewed changes

rahulbarwal reviewed Aug 20, 2024

View reviewed changes

app/client/cypress/locators/commonlocators.json Outdated Show resolved Hide resolved

updated-commonlocators-variables-location

99640bf

coderabbitai bot reviewed Aug 20, 2024

View reviewed changes

app/client/cypress/e2e/Regression/ClientSide/Widgets/Select/Select2_Spec.ts Outdated Show resolved Hide resolved

fix-duplication

92f3d2a

coderabbitai bot reviewed Aug 20, 2024

View reviewed changes

rahulbarwal reviewed Aug 20, 2024

View reviewed changes

app/client/cypress/e2e/Regression/ClientSide/Widgets/Select/Select2_Spec.ts Outdated Show resolved Hide resolved

...ent/cypress/e2e/Regression/ClientSide/Widgets/ListV2/Childwigets/List_Select_Widgets_spec.js Outdated Show resolved Hide resolved

removed-unwanted-changes

29a20a6

coderabbitai bot reviewed Aug 20, 2024

View reviewed changes

rahulbarwal added the Widgets & Accelerators Pod Issues related to widgets & Accelerators label Aug 20, 2024

rahulbarwal approved these changes Aug 20, 2024

View reviewed changes

sagar-qa007 approved these changes Aug 28, 2024

View reviewed changes

yatinappsmith merged commit 5ddf6e6 into appsmithorg:release Aug 28, 2024
3 checks passed

rahulbarwal mentioned this pull request Sep 26, 2024

[Feature]: Remove option to clear option when select widget is required #34262

Closed

1 task

coderabbitai bot mentioned this pull request Nov 1, 2024

TESTING EXTERNAL SCRIPT: external merge request from Contributor #37185

Closed

2 tasks

coderabbitai bot mentioned this pull request Nov 21, 2024

DO not merge : In testing: new test cases framework functions #37566

Open

2 tasks

feat: remove-clear-option-for-required-select-widget #35060

feat: remove-clear-option-for-required-select-widget #35060

Conversation

AnnaHariprasad5123 commented Jul 22, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

Summary by CodeRabbit

coderabbitai bot commented Jul 22, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

AnnaHariprasad5123 commented Jul 25, 2024

NilanshBansal commented Jul 29, 2024

github-actions bot commented Aug 5, 2024

AnnaHariprasad5123 commented Aug 8, 2024

NilanshBansal commented Aug 8, 2024

rahulbarwal commented Aug 9, 2024

AnnaHariprasad5123 commented Aug 9, 2024 • edited Loading

coderabbitai bot left a comment

Choose a reason for hiding this comment

AnnaHariprasad5123 commented Aug 13, 2024

rahulbarwal commented Aug 14, 2024

AnnaHariprasad5123 commented Aug 14, 2024

rahulbarwal commented Aug 15, 2024

AnnaHariprasad5123 commented Aug 15, 2024 • edited Loading

coderabbitai bot left a comment

Choose a reason for hiding this comment

AnnaHariprasad5123 commented Aug 19, 2024

rahulbarwal commented Aug 19, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

AnnaHariprasad5123 commented Aug 19, 2024 • edited Loading

AnnaHariprasad5123 commented Aug 19, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

AnnaHariprasad5123 commented Aug 20, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

AnnaHariprasad5123 commented Aug 20, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

rahulbarwal left a comment

Choose a reason for hiding this comment

rahulbarwal commented Aug 20, 2024

rahulbarwal commented Aug 22, 2024

AnnaHariprasad5123 commented Aug 23, 2024

rahulbarwal commented Aug 23, 2024

AnnaHariprasad5123 commented Aug 28, 2024

AnnaHariprasad5123 commented Jul 22, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 22, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

AnnaHariprasad5123 commented Aug 9, 2024 •

edited

Loading

AnnaHariprasad5123 commented Aug 15, 2024 •

edited

Loading

AnnaHariprasad5123 commented Aug 19, 2024 •

edited

Loading