-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: switch branch spec ce #35312
test: switch branch spec ce #35312
Conversation
WalkthroughThe recent changes enhance the testing framework for Git synchronization in the Cypress suite by adopting a helper function for input assertions, which promotes modularity and maintainability. Additionally, the focus of the limited tests has shifted from one specification to another, indicating a refined testing strategy. These updates aim to improve code clarity and execution efficiency, reflecting a commitment to best practices in testing. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Cypress
participant agHelper
User->>Cypress: Initiate Git Sync Test
Cypress->>agHelper: Assert Attribute for Branch Name
agHelper-->>Cypress: Return Assertion Result
Cypress->>User: Test Execution Complete
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
/ci-test-limit |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10178031360. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Commits
Files that changed from the base of the PR and between d780ecb and e812a9bc9b9ad10fb5fcf4e53ff8fc4faf58ecce.
Files ignored due to path filters (1)
app/client/cypress/downloads/kiwi.svg
is excluded by!**/*.svg
Files selected for processing (2)
- app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/SwitchBranches_spec.js (2 hunks)
- app/client/cypress/limited-tests.txt (1 hunks)
Files skipped from review due to trivial changes (1)
- app/client/cypress/limited-tests.txt
Additional context used
Path-based instructions (1)
app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/SwitchBranches_spec.js (1)
Pattern
app/client/cypress/**/**.*
: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
Additional comments not posted (2)
app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/SwitchBranches_spec.js (2)
43-45
: Good use ofagHelper.AssertAttribute
for assertions.The change to use
agHelper.AssertAttribute
improves code readability and maintainability.
52-54
: Good use ofagHelper.AssertAttribute
for assertions.The change to use
agHelper.AssertAttribute
improves code readability and maintainability.
e812a9b
to
6a06e22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Commits
Files that changed from the base of the PR and between e812a9bc9b9ad10fb5fcf4e53ff8fc4faf58ecce and 6a06e22.
Files selected for processing (2)
- app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/SwitchBranches_spec.js (2 hunks)
- app/client/cypress/limited-tests.txt (1 hunks)
Files skipped from review due to trivial changes (1)
- app/client/cypress/limited-tests.txt
Files skipped from review as they are similar to previous changes (1)
- app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/SwitchBranches_spec.js
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10178031360. |
/ci-test-limit runId=10178031360 |
10 similar comments
/ci-test-limit runId=10178031360 |
/ci-test-limit runId=10178031360 |
/ci-test-limit runId=10178031360 |
/ci-test-limit runId=10178031360 |
/ci-test-limit runId=10178031360 |
/ci-test-limit runId=10178031360 |
/ci-test-limit runId=10178031360 |
/ci-test-limit runId=10178031360 |
/ci-test-limit runId=10178031360 |
/ci-test-limit runId=10178031360 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10178654300. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10178654247. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10178654002. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10178655186. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10178655482. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10178655178. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10178656366. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10178657569. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10178657884. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10178656969. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10178654300. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10178654247. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10178655178. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10178655482. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10178657569. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10178657584. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10178656366. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10178655186. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10178657884. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10178654002. |
Enabled Test
Replaced some validations with should with aghelper assertions
EE: https://github.com/appsmithorg/appsmith-ee/pull/4755
/ok-to-test tags="@tag.Sanity"
Summary by CodeRabbit
Bug Fixes
Chores
SwitchBranches_spec.js
, changing the test execution target.Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10181073301
Commit: 41db4eb
Cypress dashboard.
Tags:
@tag.Sanity
Spec:
Wed, 31 Jul 2024 13:48:05 UTC