-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Un commented yarn cache #35668
Conversation
WalkthroughThe change enhances the GitHub Actions workflow by re-enabling the restoration of the Yarn cache during CI testing. This adjustment allows the workflow to utilize cached dependencies more efficiently in the event of a failure, reducing build times in future runs. The cache is managed based on the Changes
Assessment against linked issues
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/ci-test-limited-with-count.yml (1 hunks)
Additional comments not posted (1)
.github/workflows/ci-test-limited-with-count.yml (1)
212-219
: Great job re-enabling the Yarn cache!Uncommenting the
Restore Yarn cache
step is a smart move to improve build efficiency. The cache key based on theyarn.lock
file ensures that dependencies are correctly versioned. This will help reduce build times, especially after a failure.
/ci-test-limit-count run_count=2 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10370012788. |
Description
Having seen memory failure in EE repo for the yarn install. This same steps works fine in CE.
Fixes #
35667
Automation
/ok-to-test tags="@tag.Sanity"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10369580919
Commit: 29e0b8d
Cypress dashboard.
Tags:
@tag.Sanity
Spec:
Tue, 13 Aug 2024 12:37:35 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
Bug Fixes
Chores