Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Un commented yarn cache #35668

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

sagar-qa007
Copy link
Contributor

@sagar-qa007 sagar-qa007 commented Aug 13, 2024

Description

Having seen memory failure in EE repo for the yarn install. This same steps works fine in CE.

Fixes #35667

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10369580919
Commit: 29e0b8d
Cypress dashboard.
Tags: @tag.Sanity
Spec:


Tue, 13 Aug 2024 12:37:35 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Bug Fixes

    • Restored the Yarn cache during workflow execution in case of failure, improving build efficiency.
  • Chores

    • Updated GitHub Actions workflow to enhance caching mechanism for better performance in CI processes.

Copy link
Contributor

coderabbitai bot commented Aug 13, 2024

Walkthrough

The change enhances the GitHub Actions workflow by re-enabling the restoration of the Yarn cache during CI testing. This adjustment allows the workflow to utilize cached dependencies more efficiently in the event of a failure, reducing build times in future runs. The cache is managed based on the yarn.lock file, improving overall project performance.

Changes

Files Change Summary
.github/workflows/ci-test-limited-with-count.yml Restores Yarn cache step to workflow, conditioned on prior step failure, enhancing cache efficiency.

Assessment against linked issues

Objective Addressed Explanation
Need to re-enable yarn cache for EE repo in workflow (#35667)

In the workflow's dance, a cache reappears,
Restoring the Yarn brings joy and cheers!
With dependencies swift, the builds will fly,
A faster pipeline, oh my, oh my!
So let's celebrate this change, so bright,
In the realm of code, everything feels right! 🌟


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Aug 13, 2024
@sagar-qa007 sagar-qa007 added the ok-to-test Required label for CI label Aug 13, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6f6c278 and 29e0b8d.

Files selected for processing (1)
  • .github/workflows/ci-test-limited-with-count.yml (1 hunks)
Additional comments not posted (1)
.github/workflows/ci-test-limited-with-count.yml (1)

212-219: Great job re-enabling the Yarn cache!

Uncommenting the Restore Yarn cache step is a smart move to improve build efficiency. The cache key based on the yarn.lock file ensures that dependencies are correctly versioned. This will help reduce build times, especially after a failure.

@sagar-qa007 sagar-qa007 merged commit ec4a376 into release Aug 13, 2024
46 checks passed
@sagar-qa007 sagar-qa007 deleted the fix/memoryissuewithoutyarncache branch August 13, 2024 12:39
@sagar-qa007
Copy link
Contributor Author

/ci-test-limit-count run_count=2

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants