feat: Updated subtitle position to bottom

[albinAppsmith]

Description

This PR updates the placement of sub title text to the bottom of the form control. And this will not be applicable to

1. ARRAY_FIELD
2. WHERE_CLAUSE
3. QUERY_DYNAMIC_TEXT

Fixes #34321

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10492518152
Commit: 9387183
Cypress dashboard.
Tags: @tag.All
Spec:

---

Wed, 21 Aug 2024 18:13:17 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features
  • Introduced conditional rendering for subtitles in the form configuration, enhancing the organization of control types.
• Style
  • Improved styling consistency for StyledFormInfo and FormSubtitleText components by refining display properties and margin logic.

[coderabbitai]

Walkthrough

The recent updates enhance the styling and rendering logic for form components in the application. Key modifications include improved conditional rendering for subtitles and styling adjustments for specific control types. These changes align the UI elements more consistently, particularly in how subtitles are displayed in relation to various control types, ultimately improving user experience and visual clarity.

Changes

File	Change Summary
app/client/src/components/editorComponents/...	Adjusted styling logic for StyledFormInfo and FormSubtitleText components including display and margin-top properties based on control types.
app/client/src/pages/Editor/FormConfig.tsx	Introduced controlsWithSubtitleInTop constant and updated rendering logic for displaying subtitles based on control types.

Assessment against linked issues

Objective	Addressed	Explanation
Update position of subtitle in UQI to bottom (#34321)	✅
Ensure specific control types remain unaffected (#34321)	❓	It is unclear if ARRAY_FIELD, WHERE_CLAUSE, and QUERY_DYNAMIC_TEXT are exempted.

🎉 In the realm of forms, a change so bright,
Subtitles now dance, a beautiful sight.
With margins aligned and logic refined,
User experience enhanced, perfectly designed! 🌟
Let the controls show their style,
Celebrating clarity, all the while!

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[albinAppsmith]

/build-deploy-preview skip-test=true

[github-actions]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10471623286.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 35789.
recreate: .

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between de8caad and ccd6ffa.

Files selected for processing (2)

• app/client/src/components/editorComponents/form/fields/StyledFormComponents.tsx (3 hunks)
• app/client/src/pages/Editor/FormConfig.tsx (5 hunks)

Additional comments not posted (5)

app/client/src/components/editorComponents/form/fields/StyledFormComponents.tsx (2)

11-12: Great job on refining the styling logic!

The adjustments to the display and margin-top properties for SWITCH and CHECKBOX control types enhance the visual alignment. Removing the semicolon also improves CSS syntax consistency.

Also applies to: 22-27

---

38-43: Consistent styling updates!

The modification of the display property aligns with the changes made in StyledFormInfo, ensuring uniformity in style declarations across components.

app/client/src/pages/Editor/FormConfig.tsx (3)

71-75: Good use of constants for maintainability!

Introducing controlsWithSubtitleInTop centralizes the logic for determining subtitle placement, making the code more maintainable and easier to update.

---

Line range hint 196-253: Improved subtitle rendering logic!

Using shouldRenderSubtitle to determine subtitle rendering enhances the clarity and maintainability of the rendering logic.

---

271-276: Well-aligned subtitle rendering!

The conditional rendering of subtitles based on controlsWithSubtitleInTop ensures that subtitles are displayed correctly, aligning with the PR objectives.

[github-actions]

Deploy-Preview-URL: https://ce-35789.dp.appsmith.com

[albinAppsmith]

/build-deploy-preview skip-test=true

[github-actions]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10483710031.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 35789.
recreate: .

[github-actions]

Deploy-Preview-URL: https://ce-35789.dp.appsmith.com

[albinAppsmith]

/build-deploy-preview skip-test=true

[github-actions]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10492528424.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 35789.
recreate: .

[github-actions]

Deploy-Preview-URL: https://ce-35789.dp.appsmith.com