fix: Fall of the error toasts wall

app/client/src/actions/jsActionActions.ts

@@ -8,6 +8,7 @@ import type { JSCollection } from "entities/JSCollection";
 import type { CreateJSCollectionRequest } from "ee/api/JSActionAPI";
 import type { EventLocation } from "ee/utils/analyticsUtilTypes";
 import type { ApiResponse } from "api/ApiResponses";
+import type { ErrorPayloadType } from "../sagas/ErrorSagas";
 
 export interface FetchJSCollectionsPayload {
   applicationId: string;
@@ -65,6 +66,7 @@ export const copyJSCollectionSuccess = (payload: JSCollection) => {
 export const copyJSCollectionError = (payload: {
   id: string;
   destinationPageId: string;
+  error?: ErrorPayloadType;
 }) => {
   return {
     type: ReduxActionErrorTypes.COPY_JS_ACTION_ERROR,
@@ -93,6 +95,7 @@ export const moveJSCollectionSuccess = (payload: JSCollection) => {
 export const moveJSCollectionError = (payload: {
   id: string;
   originalPageId: string;
+  error?: ErrorPayloadType;
 }) => {
   return {
     type: ReduxActionErrorTypes.MOVE_JS_ACTION_ERROR,

app/client/src/actions/pluginActionActions.ts

@@ -15,6 +15,7 @@ import type { ModalInfo } from "reducers/uiReducers/modalActionReducer";
 import type { OtlpSpan } from "UITelemetry/generateTraces";
 import type { ApiResponse } from "api/ApiResponses";
 import type { JSCollection } from "entities/JSCollection";
+import type { ErrorPayloadType } from "../sagas/ErrorSagas";
 
 export const createActionRequest = (payload: Partial<Action>) => {
   return {
@@ -208,6 +209,7 @@ export const moveActionSuccess = (payload: Action) => {
 export const moveActionError = (payload: {
   id: string;
   originalPageId: string;
+  error?: ErrorPayloadType;
 }) => {
   return {
     type: ReduxActionErrorTypes.MOVE_ACTION_ERROR,
@@ -236,6 +238,7 @@ export const copyActionSuccess = (payload: Action) => {
 export const copyActionError = (payload: {
   id: string;
   destinationPageId: string;
+  error?: ErrorPayloadType;
 }) => {
   return {
     type: ReduxActionErrorTypes.COPY_ACTION_ERROR,

app/client/src/ce/constants/ReduxActionConstants.tsx

@@ -368,7 +368,6 @@ const UserAuthActionTypes = {
   SAAS_GET_OAUTH_ACCESS_TOKEN: "SAAS_GET_OAUTH_ACCESS_TOKEN",
   GET_OAUTH_ACCESS_TOKEN: "GET_OAUTH_ACCESS_TOKEN",
   GET_OAUTH_ACCESS_TOKEN_SUCCESS: "GET_OAUTH_ACCESS_TOKEN_SUCCESS",
-  GET_OAUTH_ACCESS_TOKEN_ERROR: "GET_OAUTH_ACCESS_TOKEN_ERROR",
 };
 const UserAuthActionErrorTypes = {
   CREATE_USER_ERROR: "CREATE_USER_ERROR",
@@ -379,6 +378,7 @@ const UserAuthActionErrorTypes = {
   LOGOUT_USER_ERROR: "LOGOUT_USER_ERROR",
   VERIFY_INVITE_ERROR: "VERIFY_INVITE_ERROR",
   INVITED_USER_SIGNUP_ERROR: "INVITED_USER_SIGNUP_ERROR",
+  GET_OAUTH_ACCESS_TOKEN_ERROR: "GET_OAUTH_ACCESS_TOKEN_ERROR",
 };
 
 const UserProfileActionTypes = {

app/client/src/ce/sagas/JSActionSagas.ts

@@ -192,10 +192,14 @@ export function* copyJSCollectionSaga(
     }
   } catch (e) {
     const actionName = actionObject ? actionObject.name : "";
-    toast.show(createMessage(ERROR_JS_ACTION_COPY_FAIL, actionName), {
-      kind: "error",
-    });
-    yield put(copyJSCollectionError(action.payload));
+    yield put(
+      copyJSCollectionError({
+        ...action.payload,
+        error: {
+          message: createMessage(ERROR_JS_ACTION_COPY_FAIL, actionName),
+        },
+      }),
+    );
   }
 }
 
@@ -265,13 +269,13 @@ export function* moveJSCollectionSaga(
     // @ts-expect-error: response.data is of type unknown
     yield put(moveJSCollectionSuccess(response.data));
   } catch (e) {
-    toast.show(createMessage(ERROR_JS_ACTION_MOVE_FAIL, actionObject.name), {
-      kind: "error",
-    });
     yield put(
       moveJSCollectionError({
         id: action.payload.id,
         originalPageId: actionObject.pageId,
+        error: {
+          message: createMessage(ERROR_JS_ACTION_MOVE_FAIL, actionObject.name),
+        },
       }),
     );
   }
@@ -375,15 +379,14 @@ export function* saveJSObjectName(
       payload: {
         actionId: action.payload.id,
         oldName: collection.config.name,
+        error: {
+          message: createMessage(
+            ERROR_JS_COLLECTION_RENAME_FAIL,
+            action.payload.name,
+          ),
+        },
       },
     });
-    toast.show(
-      createMessage(ERROR_JS_COLLECTION_RENAME_FAIL, action.payload.name),
-      {
-        kind: "error",
-      },
-    );
-    log.error(e);
   }
 }
 

app/client/src/reducers/entityReducers/datasourceReducer.ts

@@ -370,7 +370,7 @@ const datasourceReducer = createReducer(initialState, {
       loadingTokenForDatasourceId: null,
     };
   },
-  [ReduxActionTypes.GET_OAUTH_ACCESS_TOKEN_ERROR]: (
+  [ReduxActionErrorTypes.GET_OAUTH_ACCESS_TOKEN_ERROR]: (
     state: DatasourceDataState,
   ) => {
     return {

app/client/src/sagas/ActionExecution/PluginActionSaga.ts

@@ -9,9 +9,9 @@ import {
 } from "redux-saga/effects";
 import * as Sentry from "@sentry/react";
 import type { updateActionDataPayloadType } from "actions/pluginActionActions";
-import { executePageLoadActions } from "actions/pluginActionActions";
 import {
   clearActionResponse,
+  executePageLoadActions,
   executePluginActionError,
   executePluginActionRequest,
   executePluginActionSuccess,
@@ -72,8 +72,7 @@ import {
 } from "sagas/ErrorSagas";
 import AnalyticsUtil from "ee/utils/AnalyticsUtil";
 import type { Action } from "entities/Action";
-import { ActionExecutionContext } from "entities/Action";
-import { PluginType } from "entities/Action";
+import { ActionExecutionContext, PluginType } from "entities/Action";
 import LOG_TYPE from "entities/AppsmithConsole/logtype";
 import {
   ACTION_EXECUTION_CANCELLED,
@@ -173,6 +172,7 @@ import {
 import type { JSAction, JSCollection } from "entities/JSCollection";
 import { getAllowedActionAnalyticsKeys } from "constants/AppsmithActionConstants/formConfig/ActionAnalyticsConfig";
 import { setApiPaneDebuggerState } from "../../actions/apiPaneActions";
+import { LOG_CATEGORY, Severity } from "../../entities/AppsmithConsole";
 
 enum ActionResponseDataTypes {
   BINARY = "BINARY",
@@ -1267,10 +1267,13 @@ function* executePageLoadActionsSaga(
     checkAndLogErrorsIfCyclicDependency(layoutOnLoadActionErrors);
   } catch (e) {
     log.error(e);
-
-    toast.show(createMessage(ERROR_FAIL_ON_PAGE_LOAD_ACTIONS), {
-      kind: "error",
-    });
+    AppsmithConsole.addErrors([
+      {
+        payload: { text: createMessage(ERROR_FAIL_ON_PAGE_LOAD_ACTIONS) },
+        severity: Severity.ERROR,
+        category: LOG_CATEGORY.PLATFORM_GENERATED,
+      },
+    ]);
   }
   endSpan(span);
 }

app/client/src/sagas/ActionSagas.ts

@@ -106,7 +106,6 @@ import {
   createNewQueryAction,
 } from "actions/apiPaneActions";
 import type { Plugin } from "api/PluginApi";
-import * as log from "loglevel";
 import { shouldBeDefined } from "utils/helpers";
 import {
   apiEditorIdURL,
@@ -704,13 +703,13 @@ function* moveActionSaga(
     // @ts-expect-error: response is of type unknown
     yield put(moveActionSuccess(response.data));
   } catch (e) {
-    toast.show(createMessage(ERROR_ACTION_MOVE_FAIL, actionObject.name), {
-      kind: "error",
-    });
     yield put(
       moveActionError({
         id: action.payload.id,
         originalPageId: action.payload.originalPageId,
+        error: {
+          message: createMessage(ERROR_ACTION_MOVE_FAIL, actionObject.name),
+        },
       }),
     );
   }
@@ -797,10 +796,12 @@ function* copyActionSaga(
     yield put(copyActionSuccess(payload));
   } catch (e) {
     const actionName = actionObject ? actionObject.name : "";
-    toast.show(createMessage(ERROR_ACTION_COPY_FAIL, actionName), {
-      kind: "error",
-    });
-    yield put(copyActionError(action.payload));
+    yield put(
+      copyActionError({
+        ...action.payload,
+        error: { message: createMessage(ERROR_ACTION_COPY_FAIL, actionName) },
+      }),
+    );
   }
 }
 
@@ -899,12 +900,9 @@ function* saveActionName(action: ReduxAction<{ id: string; name: string }>) {
       payload: {
         actionId: action.payload.id,
         oldName: api.config.name,
+        message: createMessage(ERROR_ACTION_RENAME_FAIL, action.payload.name),
       },
     });
-    toast.show(createMessage(ERROR_ACTION_RENAME_FAIL, action.payload.name), {
-      kind: "error",
-    });
-    log.error(e);
   }
 }
 

app/client/src/sagas/ApiPaneSagas.ts

@@ -4,7 +4,6 @@
 import get from "lodash/get";
 import omit from "lodash/omit";
 import { all, call, put, select, take, takeEvery } from "redux-saga/effects";
-import * as Sentry from "@sentry/react";
 import type {
   ReduxAction,
   ReduxActionWithMeta,
@@ -69,7 +68,6 @@ import { validateResponse } from "./ErrorSagas";
 import type { CreateDatasourceSuccessAction } from "actions/datasourceActions";
 import { removeTempDatasource } from "actions/datasourceActions";
 import { klona } from "klona/lite";
-import { toast } from "@appsmith/ads";
 import type { AutoGeneratedHeader } from "pages/Editor/APIEditor/helpers";
 import { deriveAutoGeneratedHeaderState } from "pages/Editor/APIEditor/helpers";
 import { TEMP_DATASOURCE_ID } from "constants/Datasource";
@@ -744,19 +742,14 @@ function* handleApiNameChangeSuccessSaga(
   const actionObj: Action | undefined = yield select(getAction, actionId);
   yield take(ReduxActionTypes.FETCH_ACTIONS_FOR_PAGE_SUCCESS);
   if (!actionObj) {
-    // Error case, log to sentry
-    toast.show(createMessage(ERROR_ACTION_RENAME_FAIL, ""), {
-      kind: "error",
-    });
-
-    Sentry.captureException(
-      new Error(createMessage(ERROR_ACTION_RENAME_FAIL, "")),
-      {
-        extra: {
-          actionId: actionId,
-        },
+    yield put({
+      type: ReduxActionErrorTypes.SAVE_ACTION_NAME_ERROR,
+      payload: {
+        actionId,
+        error: { message: createMessage(ERROR_ACTION_RENAME_FAIL, "") },
+        logToSentry: true,
       },
-    );
+    });
     return;
   }
   if (actionObj.pluginType === PluginType.API) {

app/client/src/sagas/DatasourcesSagas.ts

@@ -468,12 +468,9 @@ export function* deleteDatasourceSaga(
       yield select(getDatasource, actionPayload.payload.id),
       `Datasource not found for id - ${actionPayload.payload.id}`,
     );
-    toast.show((error as Error).message, {
-      kind: "error",
-    });
     yield put({
       type: ReduxActionErrorTypes.DELETE_DATASOURCE_ERROR,
-      payload: { error, id: actionPayload.payload.id, show: false },
+      payload: { error, id: actionPayload.payload.id },
     });
     AppsmithConsole.error({
       text: (error as Error).message,
@@ -733,12 +730,12 @@ function* getOAuthAccessTokenSaga(
   if (!appsmithToken) {
     // Error out because auth token should been here
     log.error(OAUTH_APPSMITH_TOKEN_NOT_FOUND);
-    toast.show(OAUTH_AUTHORIZATION_APPSMITH_ERROR, {
-      kind: "error",
-    });
     yield put({
-      type: ReduxActionTypes.GET_OAUTH_ACCESS_TOKEN_ERROR,
-      payload: { datasourceId: datasourceId },
+      type: ReduxActionErrorTypes.GET_OAUTH_ACCESS_TOKEN_ERROR,
+      payload: {
+        datasourceId: datasourceId,
+        message: OAUTH_AUTHORIZATION_APPSMITH_ERROR,
+      },
     });
     return;
   }
@@ -797,11 +794,11 @@ function* getOAuthAccessTokenSaga(
     }
   } catch (e) {
     yield put({
-      type: ReduxActionTypes.GET_OAUTH_ACCESS_TOKEN_ERROR,
-      payload: { datasourceId: datasourceId },
-    });
-    toast.show(OAUTH_AUTHORIZATION_FAILED, {
-      kind: "error",
+      type: ReduxActionErrorTypes.GET_OAUTH_ACCESS_TOKEN_ERROR,
+      payload: {
+        datasourceId: datasourceId,
+        message: OAUTH_AUTHORIZATION_FAILED,
+      },
     });
     log.error(e);
   }
@@ -910,25 +907,19 @@ function* testDatasourceSaga(actionPayload: ReduxAction<Datasource>) {
       }
       if (responseData.invalids && responseData.invalids.length) {
         AnalyticsUtil.logEvent("TEST_DATA_SOURCE_FAILED", {
-          datasoureId: datasource?.id,
+          datasourceId: datasource?.id,
           environmentId: currentEnvironment,
           environmentName: currentEnvDetails.name,
           pluginName: plugin?.name,
           errorMessages: responseData.invalids,
           messages: responseData.messages,
         });
-        responseData.invalids.forEach((message: string) => {
-          toast.show(message, {
-            kind: "error",
-          });
-        });
         yield put({
           type: ReduxActionErrorTypes.TEST_DATASOURCE_ERROR,
           payload: {
-            show: false,
             id: datasource.id,
             environmentId: currentEnvironment,
-            messages: messages,
+            message: responseData.invalids.join(", "),
           },
         });
         AppsmithConsole.error({
@@ -2100,10 +2091,7 @@ function* updateDatasourceAuthStateSaga(
   } catch (error) {
     yield put({
       type: ReduxActionErrorTypes.UPDATE_DATASOURCE_ERROR,
-      payload: { error },
-    });
-    toast.show(OAUTH_AUTHORIZATION_FAILED, {
-      kind: "error",
+      payload: { error, message: OAUTH_AUTHORIZATION_FAILED },
     });
   }
 }