chore: Revert "fix: Add mode property to forkApplicationSaga"

[brayn003]

Description

Reverts #35841

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10555144301
Commit: f01f27d
Cypress dashboard.
Tags: @tag.All
Spec:

---

Mon, 26 Aug 2024 08:05:27 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

[coderabbitai]

Walkthrough

The recent changes involve modifications to the forkApplicationSaga function and the pageListReducer. The forkApplicationSaga has had its payload structure simplified by removing the mode property, while the pageListReducer has eliminated the currentBasePageId and currentPageId properties from its state updates. These alterations aim to streamline the codebase and potentially enhance the overall state management.

Changes

Files	Change Summary
app/client/src/ce/sagas/ApplicationSagas.tsx, app/client/src/reducers/entityReducers/pageListReducer.tsx	The forkApplicationSaga function has removed the mode property from its payload, simplifying its structure. The pageListReducer has eliminated the currentBasePageId and currentPageId properties from its state updates, suggesting a simplification of state management.

Poem

In code we find a clearer way,
With modes and IDs swept away.
A saga light, a reducer neat,
The structure's lean, its rhythm sweet.
Simplified paths, less weight to bear,
In every line, a breath of air! ✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9889117 and f01f27d.

Files selected for processing (2)

• app/client/src/ce/sagas/ApplicationSagas.tsx (1 hunks)
• app/client/src/reducers/entityReducers/pageListReducer.tsx (1 hunks)

Files skipped from review due to trivial changes (1)

• app/client/src/ce/sagas/ApplicationSagas.tsx

Additional comments not posted (2)

app/client/src/reducers/entityReducers/pageListReducer.tsx (2)

Line range hint 13-14: Good job simplifying the initial state!

Removing currentBasePageId and currentPageId from the initialState object helps in reducing complexity and improving performance.

The code changes are approved.

---

Line range hint 79-89: Excellent work streamlining the state management!

Removing currentBasePageId and currentPageId from the state update logic in the ReduxActionTypes.SWITCH_CURRENT_PAGE_ID case helps in simplifying the reducer's functionality.

The code changes are approved.