feat: Action redesign: Updating the config for Databricks plugin to use sections and zones format #36057

ankitakinger · 2024-09-02T14:34:18Z

Description

Action redesign: Updating the config for Databricks plugin to use sections and zones format

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10791230950
Commit: a7ba129
Cypress dashboard.
Tags: @tag.All
Spec:

Tue, 10 Sep 2024 14:00:44 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

New Features
- Updated the plugin configuration to enhance the section control, improving the user interface and overall experience.
- Introduced a new layout structure with a SINGLE_COLUMN_ZONE control type for better organization and potential functionality expansion.
Improvements
- Enhanced naming conventions for identifiers, making them more descriptive and contextually relevant.

coderabbitai · 2024-09-02T14:34:26Z

Walkthrough

The changes involve a significant update to the JSON configuration of the Databricks plugin, specifically altering control types and identifiers to enhance the structure and organization. The controlType has been updated to SECTION_V2, and a new SINGLE_COLUMN_ZONE has been introduced to encapsulate existing elements, reflecting a modular approach to configuration.

Changes

File Path	Change Summary
`app/server/appsmith-plugins/databricksPlugin/...`	Updated `controlType` from `SECTION` to `SECTION_V2`, changed `identifier` from `SELECTOR` to `SELECTOR-Z1`, and introduced `SINGLE_COLUMN_ZONE` while retaining existing child properties.

Assessment against linked issues

Objective	Addressed	Explanation
Add Zone & Section to Databricks plugin form (#35489)	✅

Changes in code, oh what a delight,
Sections and zones now shine so bright.
With SECTION_V2 leading the way,
A modular dance in JSON's ballet.
Let's celebrate this structured embrace,
Enhancing our plugin with style and grace! 🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4516129 and a99ad19.

Files selected for processing (1)

app/server/appsmith-plugins/databricksPlugin/src/main/resources/editor/root.json (1 hunks)

Additional comments not posted (4)

app/server/appsmith-plugins/databricksPlugin/src/main/resources/editor/root.json (4)

4-4: Great work updating the controlType to SECTION_V2! 👍

This change reflects a versioning or enhancement of the section control, which can lead to improved functionality or user experience. Keep up the good work!

5-5: Excellent job updating the identifier to SECTION-ONE! 🙌

This change reflects a more descriptive and contextually relevant naming convention, which can improve the readability and maintainability of the configuration. Your attention to detail is commendable!

8-8: Fantastic work introducing the SINGLE_COLUMN_ZONE control type! 🎉

This change reflects a shift towards a more modular and flexible configuration setup, which can enhance the user experience and extend the capabilities of the plugin. Your efforts to improve the structure are highly appreciated!

11-16: Excellent work nesting the child element under the SINGLE_COLUMN_ZONE! 👏

This change maintains the core functionality of the child element while enhancing the structural organization of the configuration. Your attention to detail in preserving the properties of the child element is commendable. Keep up the great work!

ankitakinger · 2024-09-02T14:41:02Z

/build-deploy-preview skip-tests=true

github-actions · 2024-09-02T14:41:24Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10669196313.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 36057.
recreate: .

github-actions · 2024-09-02T14:47:10Z

Deploy-Preview-URL: https://ce-36057.dp.appsmith.com

NilanshBansal · 2024-09-02T14:48:20Z

Adding @AmanAgarwal041 for review

…o action-redesign/databricks

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a99ad19 and 65e9097.

Files selected for processing (1)

app/server/appsmith-plugins/databricksPlugin/src/main/resources/editor/root.json (1 hunks)

Files skipped from review as they are similar to previous changes (1)

app/server/appsmith-plugins/databricksPlugin/src/main/resources/editor/root.json

ankitakinger · 2024-09-03T14:23:51Z

/build-deploy-preview skip-tests=true

github-actions · 2024-09-03T14:24:17Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10684894780.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 36057.
recreate: .

github-actions · 2024-09-03T14:31:44Z

Deploy-Preview-URL: https://ce-36057.dp.appsmith.com

…o action-redesign/databricks

ankitakinger · 2024-09-09T17:59:12Z

/build-deploy-preview skip-tests=true

github-actions · 2024-09-09T17:59:38Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10778637723.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 36057.
recreate: .

github-actions · 2024-09-09T18:05:44Z

Deploy-Preview-URL: https://ce-36057.dp.appsmith.com

ankitakinger · 2024-09-10T09:40:55Z

Testing completed on EE. Everything looks good.

…o action-redesign/databricks

ankitakinger · 2024-09-10T11:12:10Z

/build-deploy-preview skip-tests=true

github-actions · 2024-09-10T11:12:46Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10791277342.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 36057.
recreate: .

github-actions · 2024-09-10T11:20:03Z

Deploy-Preview-URL: https://ce-36057.dp.appsmith.com

…se sections and zones format (appsmithorg#36057) ## Description Action redesign: Updating the config for Databricks plugin to use sections and zones format Fixes appsmithorg#35489 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10791230950> > Commit: a7ba129 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10791230950&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Tue, 10 Sep 2024 14:00:44 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **New Features** - Updated the plugin configuration to enhance the section control, improving the user interface and overall experience. - Introduced a new layout structure with a `SINGLE_COLUMN_ZONE` control type for better organization and potential functionality expansion. - **Improvements** - Enhanced naming conventions for identifiers, making them more descriptive and contextually relevant.

updating config for Databricks plugin

a99ad19

github-actions bot added IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo Enhancement New feature or request labels Sep 2, 2024

coderabbitai bot reviewed Sep 2, 2024

View reviewed changes

ankitakinger added the ok-to-test Required label for CI label Sep 2, 2024

ankitakinger requested review from alex-golovanov, NilanshBansal and albinAppsmith September 2, 2024 14:46

NilanshBansal requested review from AmanAgarwal041 and removed request for NilanshBansal September 2, 2024 14:48

ankitakinger added 2 commits September 3, 2024 19:05

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

e87e65c

…o action-redesign/databricks

updating identifiers

65e9097

coderabbitai bot reviewed Sep 3, 2024

View reviewed changes

ankitakinger added 2 commits September 5, 2024 02:09

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

73bdd94

…o action-redesign/databricks

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

06a7076

…o action-redesign/databricks

AmanAgarwal041 approved these changes Sep 10, 2024

View reviewed changes

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

a7ba129

…o action-redesign/databricks

albinAppsmith approved these changes Sep 11, 2024

View reviewed changes

ankitakinger merged commit 336bc08 into release Sep 11, 2024
82 checks passed

ankitakinger deleted the action-redesign/databricks branch September 11, 2024 07:18

coderabbitai bot mentioned this pull request Sep 24, 2024

chore: [Plugin Action Form] Common Editor State #36512

Merged

2 tasks

coderabbitai bot mentioned this pull request Oct 1, 2024

chore: Updated zone and section to extend HTML attributes #36623

Merged

2 tasks

This was referenced Oct 30, 2024

chore: Query Editor full width option #37138

Merged

fix: Paddings and scrolls in Plugin Action Editor #37203

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Action redesign: Updating the config for Databricks plugin to use sections and zones format #36057

feat: Action redesign: Updating the config for Databricks plugin to use sections and zones format #36057

ankitakinger commented Sep 2, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented Sep 2, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

coderabbitai bot left a comment

ankitakinger commented Sep 2, 2024

github-actions bot commented Sep 2, 2024

github-actions bot commented Sep 2, 2024

NilanshBansal commented Sep 2, 2024

coderabbitai bot left a comment

ankitakinger commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

ankitakinger commented Sep 9, 2024

github-actions bot commented Sep 9, 2024

github-actions bot commented Sep 9, 2024

ankitakinger commented Sep 10, 2024

ankitakinger commented Sep 10, 2024

github-actions bot commented Sep 10, 2024

github-actions bot commented Sep 10, 2024

feat: Action redesign: Updating the config for Databricks plugin to use sections and zones format #36057

feat: Action redesign: Updating the config for Databricks plugin to use sections and zones format #36057

Conversation

ankitakinger commented Sep 2, 2024 • edited by github-actions bot Loading

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

coderabbitai bot commented Sep 2, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

ankitakinger commented Sep 2, 2024

github-actions bot commented Sep 2, 2024

github-actions bot commented Sep 2, 2024

NilanshBansal commented Sep 2, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

ankitakinger commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

ankitakinger commented Sep 9, 2024

github-actions bot commented Sep 9, 2024

github-actions bot commented Sep 9, 2024

ankitakinger commented Sep 10, 2024

ankitakinger commented Sep 10, 2024

github-actions bot commented Sep 10, 2024

github-actions bot commented Sep 10, 2024

ankitakinger commented Sep 2, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented Sep 2, 2024 •

edited

Loading