chore: Revert "feat: telemetry added for current linter (#36400)"

[ayushpahwa]

This reverts commit 6ab9684.

Description

PR to revert changes made in telemetry for linter

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/test js

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10936319851
Commit: 00ef320
Cypress dashboard.
Tags: @tag.JS
Spec:

---

Thu, 19 Sep 2024 07:56:21 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features

  • Simplified linting process by removing telemetry-related functionality.

• Bug Fixes

  • Improved performance and maintainability of the linting process.

• Refactor

  • Updated method for retrieving keys from an object to use standard JavaScript functionality.

[coderabbitai]

Walkthrough

This pull request introduces changes to the getLintingErrors.ts file by removing telemetry-related functionality and simplifying the key retrieval process. The startAndEndSpanForFn function, which was previously used for performance tracking during the JSHint linting process, has been eliminated. Additionally, the method for retrieving keys from the SUPPORTED_WEB_APIS object has been updated to utilize the native Object.keys method instead of a custom utility function.

Changes

File	Change Summary
app/client/src/plugins/Linting/utils/getLintingErrors.ts	Removed telemetry functionality and simplified key retrieval method.

Possibly related PRs

• feat: telemetry added for current linter #36400: This PR modifies the same getLintingErrors.ts file, introducing telemetry functionality that has been removed in this main PR.

Suggested labels

skip-changelog, ok-to-test

Suggested reviewers

• rajatagrawal
• KelvinOm
• dvj1988

In the code's dance, a change so bright,
Removed the spans, made linting light.
With keys in hand, now native and true,
Simplified paths, as good code should do.
Cheers to the tweaks, let the errors flee,
A cleaner approach, for you and for me! 🎉

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 006dbfd and 00ef320.

Files selected for processing (1)

• app/client/src/plugins/Linting/utils/getLintingErrors.ts (2 hunks)

Additional comments not posted (2)

app/client/src/plugins/Linting/utils/getLintingErrors.ts (2)

70-72: Excellent work! Using the native Object.keys method is a wise choice.

Utilizing the built-in Object.keys method to retrieve keys from an object is a standard and recommended approach in JavaScript. It simplifies the codebase by eliminating the need for a custom utility function. Keep up the good work!

Tools

Biome

[error] 71-71: The assignment should not be in an expression.

The use of assignments in expressions is confusing.
Expressions are often considered as side-effect free.

(lint/suspicious/noAssignInExpressions)

---

198-198: Splendid simplification! Removing the telemetry wrapper is a smart move.

By directly invoking the jshint function without the startAndEndSpanForFn wrapper, you have streamlined the linting process. This change not only simplifies the code but also eliminates the overhead of performance tracking, potentially leading to improved linting performance. Well done!

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.