Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replacing ted api call for resources #36472

Merged
merged 11 commits into from
Sep 25, 2024
Merged

Conversation

sagar-qa007
Copy link
Contributor

@sagar-qa007 sagar-qa007 commented Sep 23, 2024

Description

Remove third party url.

Fixes https://github.com/appsmithorg/appsmith/issues/36535

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11031926377
Commit: bf5f295
Cypress dashboard.
Tags: @tag.All
Spec:


Wed, 25 Sep 2024 12:37:04 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Updated various image and URL references in test configurations to point to local resources instead of external links, improving consistency and performance during testing.
  • Bug Fixes

    • Corrected image source URLs in multiple test files to ensure proper loading of images in the application.
  • Chores

    • Replaced outdated URLs with local Docker host URLs across numerous test files and configurations.

Copy link
Contributor

coderabbitai bot commented Sep 23, 2024

Walkthrough

This pull request focuses on updating URLs in various Cypress test files and JSON configuration files. The modifications include replacing external image URLs with local Docker host URLs, ensuring that tests utilize resources hosted internally. This change aims to improve test reliability by minimizing dependencies on external services, thereby reducing potential flakiness in the test suite.

Changes

File Path Change Summary
app/client/cypress/e2e/Regression/ClientSide/JSLibrary/Library_spec.ts Changed installation URLs for the "fast_xml_parser" library to point to local resources and added a pause command.
app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV1/TableBugs_Spec.ts, app/client/cypress/fixtures/TestDataSet1.json Updated expected image filenames and URLs to reflect new internal resource paths and modified JSON entries for consistency.
app/client/cypress/e2e/Regression/ClientSide/Widgets/DocumentViewer/DocumentViewer_spec.ts Updated JPG image URL to a new external link while PNG and PDF URLs remain unchanged.
app/client/cypress/e2e/Regression/ClientSide/Widgets/Image/Image2_Spec.ts, app/client/cypress/e2e/Regression/ClientSide/Widgets/Image/Image3_Spec.ts Updated multiple image source URLs to new external URLs hosted on Appsmith.
app/client/cypress/fixtures/ListWidgetWithDataAndButtonDSL.json, app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV1/Table_PropertyPane_1_spec.js, app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2_PropertyPane_1_spec.js Modified defaultImage URL and updated listData structure for a List Widget, and changed image URLs for test cases to local Docker host images.

Assessment against linked issues

Objective Addressed Explanation
Remove all third-party function URLs from the codebase (36535)

Possibly related PRs

Suggested labels

Task, Bug

Suggested reviewers

  • ApekshaBhosale
  • jsartisan

🌟 In the realm of testing, where changes take flight,
URLs now local, making everything right.
From distant servers to Docker's embrace,
Our tests run smoother, keeping up the pace!
With every update, our code shines anew,
In the land of Appsmith, we’ll always break through! 🌟


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 7f38880 and bf5f295.

📒 Files selected for processing (1)
  • app/client/cypress/e2e/Regression/ServerSide/ApiTests/API_Bugs_Spec.js (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/client/cypress/e2e/Regression/ServerSide/ApiTests/API_Bugs_Spec.js

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sagar-qa007 sagar-qa007 added the ok-to-test Required label for CI label Sep 23, 2024
Copy link

Failed server tests

  • com.appsmith.server.imports.internal.ImportServiceTests#importArtifactFromInvalidJsonFileWithoutArtifactTest

@sagar-qa007 sagar-qa007 changed the title In testing: chore: Replacing ted api call for resources chore: Replacing ted api call for resources Sep 25, 2024
@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Sep 25, 2024
ApekshaBhosale
ApekshaBhosale previously approved these changes Sep 25, 2024
@sagar-qa007 sagar-qa007 merged commit 73169d1 into release Sep 25, 2024
82 checks passed
@sagar-qa007 sagar-qa007 deleted the chore/thirdpartyurl branch September 25, 2024 14:11
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this pull request Sep 26, 2024
## Description
Remove third party url. 

Fixes `https://github.com/appsmithorg/appsmith/issues/36535`

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11031926377>
> Commit: bf5f295
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11031926377&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Wed, 25 Sep 2024 12:37:04 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Updated various image and URL references in test configurations to
point to local resources instead of external links, improving
consistency and performance during testing.

- **Bug Fixes**
- Corrected image source URLs in multiple test files to ensure proper
loading of images in the application.

- **Chores**
- Replaced outdated URLs with local Docker host URLs across numerous
test files and configurations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@coderabbitai coderabbitai bot mentioned this pull request Nov 13, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants