-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Replacing ted api call for resources #36472
Conversation
WalkthroughThis pull request focuses on updating URLs in various Cypress test files and JSON configuration files. The modifications include replacing external image URLs with local Docker host URLs, ensuring that tests utilize resources hosted internally. This change aims to improve test reliability by minimizing dependencies on external services, thereby reducing potential flakiness in the test suite. Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Failed server tests
|
## Description Remove third party url. Fixes `https://github.com/appsmithorg/appsmith/issues/36535` ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11031926377> > Commit: bf5f295 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11031926377&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 25 Sep 2024 12:37:04 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Updated various image and URL references in test configurations to point to local resources instead of external links, improving consistency and performance during testing. - **Bug Fixes** - Corrected image source URLs in multiple test files to ensure proper loading of images in the application. - **Chores** - Replaced outdated URLs with local Docker host URLs across numerous test files and configurations. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description
Remove third party url.
Fixes
https://github.com/appsmithorg/appsmith/issues/36535
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11031926377
Commit: bf5f295
Cypress dashboard.
Tags:
@tag.All
Spec:
Wed, 25 Sep 2024 12:37:04 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes
Chores