Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not merge running test for fix #37237

Open
wants to merge 1 commit into
base: release
Choose a base branch
from
Open

Conversation

sagar-qa007
Copy link
Contributor

@sagar-qa007 sagar-qa007 commented Nov 5, 2024

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #37234

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Chores
    • Updated test specification to focus on validating date column types in the "Table V2" widget instead of the "Fork Template" functionality.

Copy link
Contributor

coderabbitai bot commented Nov 5, 2024

Walkthrough

The changes made in this pull request involve updating the limited-tests.txt file within the Cypress testing environment. The path for a test specification file has been altered from Fork_Template_spec.js to Date_column_types_validation_spec.ts, indicating a new focus on validating date column types for the "Table V2" widget instead of the previous "Fork Template" functionality.

Changes

File Path Change Summary
app/client/cypress/limited-tests.txt Updated test specification path from Fork_Template_spec.js to Date_column_types_validation_spec.ts.

Assessment against linked issues

Objective Addressed Explanation
Verify and fix randomly failing test cases on TBP (#37234)

Possibly related PRs

Suggested labels

Bug, Test, ok-to-test, Widgets Product, Table Widget V2, Task, skip-changelog

Suggested reviewers

  • ApekshaBhosale
  • jsartisan
  • brayn003

🎉 In the realm of code where tests reside,
A shift in focus, we take in stride.
From Fork Templates to dates that align,
Validations now in the spotlight shine.
With Cypress ready, let the tests play,
For a smoother tomorrow, we pave the way! 🌟


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 6660bd9 and 4989ef4.

📒 Files selected for processing (1)
  • app/client/cypress/limited-tests.txt (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
app/client/cypress/limited-tests.txt (1)

Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:

  • Follow best practices for Cypress code and e2e automation.
  • Avoid using cy.wait in code.
  • Avoid using cy.pause in code.
  • Avoid using agHelper.sleep().
  • Use locator variables for locators and do not use plain strings.
  • Use data-* attributes for selectors.
  • Avoid Xpaths, Attributes and CSS path.
  • Avoid selectors like .btn.submit or button[type=submit].
  • Perform logins via API with LoginFromAPI.
  • Perform logout via API with LogOutviaAPI.
  • Perform signup via API with SignupFromAPI.
  • Avoid using it.only.
  • Avoid using after and aftereach in test cases.
  • Use multiple assertions for expect statements.
  • Avoid using strings for assertions.
  • Do not use duplicate filenames even with different paths.
  • Avoid using agHelper.Sleep, this.Sleep in any file in code.
🔇 Additional comments (2)
app/client/cypress/limited-tests.txt (2)

1-1: LGTM! Clear and helpful comments.

The file header comments effectively explain the purpose and usage of this configuration file.

Also applies to: 4-6


2-2: Verify the test migration and stability.

The change from .js to .ts and from template testing to date validation testing appears to be part of addressing the flaky test issues mentioned in #37234.

Let's verify the new test's existence and structure:

Consider documenting in a comment why this specific test was chosen for the limited test suite, especially if it's related to addressing stability issues.

✅ Verification successful

Test appears stable and well-structured

The test follows good practices with:

  • Clear test organization using before/beforeEach hooks
  • Reusable helper functions for common operations
  • Consistent validation patterns across all test cases
  • No usage of explicit waits, sleeps or other stability anti-patterns
  • Comprehensive coverage of different date formats
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify the new test file exists and check its content for potential stability issues
fd -e ts "Date_column_types_validation_spec.ts" app/client/cypress | xargs cat

# Check for common stability anti-patterns
rg -i "cy\.wait|cy\.pause|agHelper\.sleep|it\.only|after\(|afterEach\(" "app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/Date_column_types_validation_spec.ts"

Length of output: 5467


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sagar-qa007
Copy link
Contributor Author

/ci-test-limit-count run_count=100

Copy link

github-actions bot commented Nov 5, 2024

@sagar-qa007 sagar-qa007 reopened this Nov 12, 2024
@sagar-qa007
Copy link
Contributor Author

/ci-test-limit-count run_count=100

Copy link

@sagar-qa007
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11887729458.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 37237.
recreate: .

Copy link

Deploy-Preview-URL: https://ce-37237.dp.appsmith.com

Copy link

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant