-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not merge running test for fix #37237
base: release
Are you sure you want to change the base?
Conversation
WalkthroughThe changes made in this pull request involve updating the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)app/client/cypress/limited-tests.txt (1)Pattern
🔇 Additional comments (2)app/client/cypress/limited-tests.txt (2)
The file header comments effectively explain the purpose and usage of this configuration file. Also applies to: 4-6
The change from Let's verify the new test's existence and structure: Consider documenting in a comment why this specific test was chosen for the limited test suite, especially if it's related to addressing stability issues. ✅ Verification successfulTest appears stable and well-structured The test follows good practices with:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Verify the new test file exists and check its content for potential stability issues
fd -e ts "Date_column_types_validation_spec.ts" app/client/cypress | xargs cat
# Check for common stability anti-patterns
rg -i "cy\.wait|cy\.pause|agHelper\.sleep|it\.only|after\(|afterEach\(" "app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/Date_column_types_validation_spec.ts"
Length of output: 5467 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
/ci-test-limit-count run_count=100 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11683155460. |
/ci-test-limit-count run_count=100 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11792892860. |
/build-deploy-preview skip-tests=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11887729458. |
Deploy-Preview-URL: https://ce-37237.dp.appsmith.com |
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
Description
Tip
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
Fixes #
37234
Automation
/ok-to-test tags=""
🔍 Cypress test results
Caution
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit