Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cannot see move to page option when there are exactly two pages in the app #38328

Merged
merged 1 commit into from
Dec 24, 2024
Merged

fix: cannot see move to page option when there are exactly two pages in the app #38328

merged 1 commit into from
Dec 24, 2024

Conversation

alex-golovanov
Copy link
Contributor

@alex-golovanov alex-golovanov commented Dec 23, 2024 •
edited by github-actions bot
Loading

Description

Fixes an issue where move between pages in query context menu was not possible.

Fixes #38117

/ok-to-test tags="@tag.IDE"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12468165994
Commit: 1ef7d57
Cypress dashboard.
Tags: @tag.IDE
Spec:

Mon, 23 Dec 2024 14:47:50 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 23, 2024 •
edited
Loading

Walkthrough

The pull request modifies the rendering logic in the Move component of the App Plugin Action Editor. The change adjusts the condition for displaying page menu items, now rendering the list when there is at least one page (instead of requiring more than one page). This subtle modification allows for more flexible page menu rendering, potentially improving the user interface when dealing with single-page scenarios.

Changes

File Change Summary
app/client/src/pages/Editor/AppPluginActionEditor/components/ToolbarMenu/Move.tsx Modified conditional rendering logic to display menu items when menuPages.length is 1 or greater

Suggested labels

Bug, IDE Product, Task, IDE Pod, ok-to-test

Suggested reviewers

  • nidhi-nair
  • ankitakinger

Possibly related PRs

Poem

🖥️ In the realm of code, a change so slight,
One page or more, now comes to light
Menu items dance with newfound grace
Simplicity finds its rightful place
A tiny tweak, a developer's delight! 🚀

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c5238ff and 1ef7d57.

📒 Files selected for processing (1)
  • app/client/src/pages/Editor/AppPluginActionEditor/components/ToolbarMenu/Move.tsx (1 hunks)
🔇 Additional comments (1)
app/client/src/pages/Editor/AppPluginActionEditor/components/ToolbarMenu/Move.tsx (1)

49-49: Great job simplifying the conditional check!
Using a boolean cast via "menuPages.length" nicely covers the case of exactly one or two pages, preventing the "No pages" UI from appearing when a single page exists. This fix aligns with the PR's goal.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@alex-golovanov
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

@github-actions github-actions bot added the Bug Something isn't working label Dec 23, 2024
@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12468148527.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 38328.
recreate: .

@github-actions github-actions bot added High This issue blocks a user from building or impacts a lot of users IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Integrations Product Issues related to a specific integration Needs Triaging Needs attention from maintainers to triage Query & JS Pod Issues related to the query & JS Pod Query Forms Isuses related to the query forms Release labels Dec 23, 2024
@alex-golovanov alex-golovanov added the ok-to-test Required label for CI label Dec 23, 2024
@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-38328.dp.appsmith.com

@alex-golovanov alex-golovanov merged commit 16953b8 into release Dec 24, 2024
48 checks passed
@alex-golovanov alex-golovanov deleted the fix/38117-pages-not-in-select branch December 24, 2024 07:12
@coderabbitai coderabbitai bot mentioned this pull request Dec 25, 2024
Merged
2 tasks
NandanAnantharamu pushed a commit that referenced this pull request Dec 27, 2024
@alex-golovanov
fix: cannot see move to page option when there are exactly two pages …
73d9fbe 
…in the app (#38328)

## Description
Fixes an issue where move between pages in query context menu was not
possible.

Fixes [#38117](#38117)

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12468165994>
> Commit: 1ef7d57
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12468165994&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`
> Spec:
> <hr>Mon, 23 Dec 2024 14:47:50 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this pull request Feb 7, 2025
@alex-golovanov
fix: cannot see move to page option when there are exactly two pages …
38d31ca 
…in the app (appsmithorg#38328)

## Description
Fixes an issue where move between pages in query context menu was not
possible.

Fixes [appsmithorg#38117](appsmithorg#38117)

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12468165994>
> Commit: 1ef7d57
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12468165994&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`
> Spec:
> <hr>Mon, 23 Dec 2024 14:47:50 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hetunandu hetunandu hetunandu approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working High This issue blocks a user from building or impacts a lot of users IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Integrations Product Issues related to a specific integration Needs Triaging Needs attention from maintainers to triage ok-to-test Required label for CI Query Forms Isuses related to the query forms Query & JS Pod Issues related to the query & JS Pod Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Action redesign - Unable to see Pages in Move to Page dropdown when there are just two pages.
2 participants
@alex-golovanov @hetunandu