Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SSH key dropdown scrolls with modal #38584

Merged
merged 1 commit into from
Jan 10, 2025
Merged

fix: SSH key dropdown scrolls with modal #38584

merged 1 commit into from
Jan 10, 2025

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jan 10, 2025 •
edited by mohanarpit
Loading

Description

This changes the dropdown container to fix overflow issues in the Git connect/import modal. The SSH key dropdown now properly scrolls with the modal content instead of remaining fixed in place.

Fixes #38436

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual testing of dropdown scroll behavior in the Git connect modal

Link to Devin run: https://app.devin.ai/sessions/be239c326a7149eaaefe6f6c39d58470

Automation

/test sanity

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12710679010
Commit: 40cdbf4
Cypress dashboard.
Tags: @tag.Sanity
Spec:

Fri, 10 Jan 2025 14:28:55 UTC

@devin-ai-integration @mohanarpit
fix: Make SSH key dropdown scroll with modal
40cdbf4 
Co-Authored-By: arpit@appsmith.com <arpit@appsmith.com>
@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 10, 2025 •
edited
Loading

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Free review on us!

CodeRabbit is offering free reviews until Wed Jan 15 2025 to showcase some of the refinements we've made.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Bug Something isn't working label Jan 10, 2025
@mohanarpit
Copy link
Member

/build-deploy-preview

@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12710306742.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 38584.
recreate: .

@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-38584.dp.appsmith.com

@mohanarpit mohanarpit requested a review from brayn003 January 10, 2025 13:41
@mohanarpit mohanarpit added the ok-to-test Required label for CI label Jan 10, 2025
@mohanarpit mohanarpit merged commit 057c626 into release Jan 10, 2025
47 checks passed
@mohanarpit mohanarpit deleted the devin/1736514776-fix-sshkey-dropdown branch January 10, 2025 17:22
@github-actions github-actions bot added Git Product Issues related to version control product Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Packages & Git Pod All issues belonging to Packages and Git Production labels Jan 13, 2025
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this pull request Feb 7, 2025
@devin-ai-integration @mohanarpit
fix: SSH key dropdown scrolls with modal (appsmithorg#38584)
819817b 
## Description

This changes the dropdown container to fix overflow issues in the Git
connect/import modal. The SSH key dropdown now properly scrolls with the
modal content instead of remaining fixed in place.

## Type of Change
- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?
- Manual testing of dropdown scroll behavior in the Git connect modal

Link to Devin run:
https://app.devin.ai/sessions/be239c326a7149eaaefe6f6c39d58470

## Automation

/test sanity

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12710679010>
> Commit: 40cdbf4
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12710679010&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Fri, 10 Jan 2025 14:28:55 UTC
<!-- end of auto-generated comment: Cypress test results  -->

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: arpit@appsmith.com <arpit@appsmith.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brayn003 brayn003 brayn003 approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Git Product Issues related to version control product Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage ok-to-test Required label for CI Packages & Git Pod All issues belonging to Packages and Git Production
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: SSH key dropdown overflows in git connect/import modal
2 participants
@mohanarpit @brayn003