-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose --appsmith-theme-fontFamily #38700
Conversation
Co-Authored-By: nikhil@appsmith.com <nikhil@appsmith.com>
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
/build-deploy-preview skip-tests=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12807708525. |
Deploy-Preview-URL: https://ce-38700.dp.appsmith.com |
…dd font-family to reset.css Co-Authored-By: nikhil@appsmith.com <nikhil@appsmith.com>
/build-deploy-preview skip-tests=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12824156267. |
Deploy-Preview-URL: https://ce-38700.dp.appsmith.com |
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: nikhil@appsmith.com <nikhil@appsmith.com>
Exposed font family variable like other theme vars.
This PR exposes the font family as a CSS variable (--appsmith-theme-fontFamily) to custom widgets, following the same pattern as other theme variables like --appsmith-theme-primaryColor. Key changes:
Link to Devin run: https://app.devin.ai/sessions/b301ccf5b4b54ae1aa7e3b4cf2930928
Fixes #38680
Automation
/ok-to-test tags="@tag.Widget"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12823827204
Commit: dc00483
Cypress dashboard.
Tags:
@tag.Widget
Spec:
Fri, 17 Jan 2025 07:45:02 UTC