fix: Issue for enter with shift

[sagar-qa007]

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Datasource"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13013150874
Commit: 5a1dd81
Cypress dashboard.
Tags: @tag.Datasource
Spec:

---

Tue, 28 Jan 2025 15:41:37 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Tests
  • Temporarily disabled a keyboard navigation test case in the API validation test suite.

[coderabbitai]

Walkthrough

The pull request involves modifying a Cypress test case in the API_RunValidations_spec.ts file. Specifically, the test case for keyboard navigation validation has been updated to be skipped during test execution by using it.skip(). This means the test will be temporarily disabled without removing its implementation, allowing for future re-enablement or investigation.

Changes

File	Change Summary
app/client/cypress/e2e/Regression/ServerSide/ApiTests/API_RunValidations_spec.ts	Skipped keyboard navigation test case by adding .skip() to the test declaration

Possibly related PRs

• test: Api curl remaining cases #38753: Introduces new test cases in the same file related to keyboard navigation and Run button functionality

Suggested Labels

Bug, Test

Suggested Reviewers

• ApekshaBhosale
• NandanAnantharamu

Poem

🧪 A test case sleeps, quietly skipped
Keyboard navigation, momentarily clipped
Cypress whispers, "Not today, my friend"
Debugging paused, awaiting its mend
Silent code, a temporary rest 🔍

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b62c875 and 5a1dd81.

📒 Files selected for processing (1)

• app/client/cypress/e2e/Regression/ServerSide/ApiTests/API_RunValidations_spec.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

app/client/cypress/e2e/Regression/ServerSide/ApiTests/API_RunValidations_spec.ts (1)

Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:

• Follow best practices for Cypress code and e2e automation.
• Avoid using cy.wait in code.
• Avoid using cy.pause in code.
• Avoid using agHelper.sleep().
• Use locator variables for locators and do not use plain strings.
• Use data-* attributes for selectors.
• Avoid Xpaths, Attributes and CSS path.
• Avoid selectors like .btn.submit or button[type=submit].
• Perform logins via API with LoginFromAPI.
• Perform logout via API with LogOutviaAPI.
• Perform signup via API with SignupFromAPI.
• Avoid using it.only.
• Avoid using after and aftereach in test cases.
• Use multiple assertions for expect statements.
• Avoid using strings for assertions.
• Do not use duplicate filenames even with different paths.
• Avoid using agHelper.Sleep, this.Sleep in any file in code.

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: perform-test / rts-build / build
• GitHub Check: perform-test / server-build / server-unit-tests
• GitHub Check: perform-test / client-build / client-build
• GitHub Check: client-unit-tests / client-unit-tests
• GitHub Check: client-prettier / prettier-check
• GitHub Check: client-lint / client-lint
• GitHub Check: client-build / client-build

🔇 Additional comments (1)

app/client/cypress/e2e/Regression/ServerSide/ApiTests/API_RunValidations_spec.ts (1)

29-29: Clarify the reason for skipping this test.

The PR objective mentions fixing an issue with "enter with shift", but this test is about Cmd/Ctrl + Enter functionality. Please explain:

1. Why is this test being skipped?
2. Is this related to the shift+enter issue mentioned in the PR?
3. What's the plan to re-enable this test?

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.