fix: Wrong url set for Editor

[hetunandu]

Description

Fixes the wrong url set for Editor CTA in sidebar. This happened during the refactor of Sidebar buttons

Automation

/ok-to-test tags="@tag.IDE"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13236899041
Commit: 9d507db
Cypress dashboard.
Tags: @tag.IDE
Spec:

---

Mon, 10 Feb 2025 09:21:06 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Refactor
  • Updated the configuration for the top button in the Editor interface to remove its fixed label. This change streamlines the button's display and behavior, offering a cleaner and more intuitive experience in the editor view. The update improves the overall visual consistency of the toolbar while all other interface elements remain unchanged.

[coderabbitai]

Walkthrough

The pull request updates the TopButtons export in the SidebarButtons.ts file by changing the argument passed to the EditorButton function from "editor" to an empty string "". The modification alters the button's designation while leaving the BottomButtons function unchanged.

Changes

File	Change Summary
app/.../SidebarButtons.ts	Changed TopButtons export from [EditorButton("editor")] to [EditorButton("")].

Suggested labels

Bug, IDE Product, IDE Pod, ok-to-test

Suggested reviewers

• ankitakinger
• albinAppsmith

Poem

A little tweak in code today,
A change to guide the button's way,
From "editor" to an empty call,
A quiet shift admired by all.
With joy, our sidebar stands anew,
Code flows in rhythms fresh and true.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3fb7555 and 9d507db.

📒 Files selected for processing (1)

• app/client/src/ce/pages/Editor/IDE/constants/SidebarButtons.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: perform-test / rts-build / build
• GitHub Check: perform-test / server-build / server-unit-tests
• GitHub Check: client-unit-tests / client-unit-tests
• GitHub Check: client-lint / client-lint
• GitHub Check: client-build / client-build
• GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
• GitHub Check: client-prettier / prettier-check

🔇 Additional comments (1)

app/client/src/ce/pages/Editor/IDE/constants/SidebarButtons.ts (1)

26-26: Verify the empty string parameter behavior.

The change from "editor" to "" aligns with the PR objective to fix the Editor CTA URL. However, let's verify that the EditorButton function handles empty string parameters correctly.

❌ Verification inconclusive

🏁 Script executed:

#!/bin/bash
# Search for EditorButton implementation and its URL handling
ast-grep --pattern 'function EditorButton($_) {
  $$$
}'

Length of output: 58

---

Let's further investigate the implementation of EditorButton to confirm that it handles an empty string parameter correctly. I'll run a shell script to search for its definition in the codebase.

Once we see the results, we can verify if the empty string parameter is valid.

---

🏁 Script executed:

#!/bin/bash
echo "Searching for traditional function definitions for EditorButton:"
rg -n "function EditorButton" .
echo "-----------------------"
echo "Searching for arrow function definitions or const assignment for EditorButton:"
rg -n "const EditorButton\s*\(" .

Length of output: 430

---

Action Required: Verify Empty Parameter Handling in EditorButton

The change to pass an empty string instead of "editor" aligns with the PR objective to fix the Editor CTA URL. However, our search didn't reveal the explicit definition for EditorButton. This suggests its implementation is defined elsewhere—possibly imported from a shared module—so its handling of an empty string isn’t readily verifiable by code search alone.

• Confirm that passing an empty string results in the correct URL as intended.
• Validate via manual testing or by reviewing the imported module containing the EditorButton logic.

Given the inconclusive evidence from our automated checks, please manually verify that this change yields the correct behavior.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[hetunandu]

/build-deploy-preview

[github-actions]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/13236897443.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 39149.
recreate: .

[github-actions]

Deploy-Preview-URL: https://ce-39149.dp.appsmith.com